Summary: | Streamline messages following batch record modification | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 17147 - Streamline messages following batch record modification
[SIGNED-OFF] Bug 17147 - Streamline messages following batch record modification Bug 17147 [Revised] Streamline messages following batch record modification [SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record modification [SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record modification Bug 17147 [Revised] Streamline messages following batch record modification |
Description
Owen Leonard
2016-08-18 15:04:12 UTC
Created attachment 54572 [details] [review] Bug 17147 - Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. Created attachment 54725 [details] [review] [SIGNED-OFF] Bug 17147 - Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Created attachment 54932 [details] [review] Bug 17147 [Revised] Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. - Submit a list of biblionumbers using a MARC modification template which contains no actions. Confirm that the resulting error message is correctly formatted. Revision formats the error messages without the unordered list, which was giving them padding which didn't look correct inside a dialog. Created attachment 54963 [details] [review] [SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. - Submit a list of biblionumbers using a MARC modification template which contains no actions. Confirm that the resulting error message is correctly formatted. Revision formats the error messages without the unordered list, which was giving them padding which didn't look correct inside a dialog. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Comment on attachment 54963 [details] [review] [SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record modification Review of attachment 54963 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/css/staff-global.css @@ +1138,5 @@ > margin-top : .7em; > } > > +div.message ul.fa-ul { > + padding-left: 1em; We don't use fa-ul in this template, why do you change its padding-left? Waiting for an answer. Created attachment 55345 [details] [review] [SIGNED-OFF] Bug 17147 [Revised] Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. - Submit a list of biblionumbers using a MARC modification template which contains no actions. Confirm that the resulting error message is correctly formatted. Revision formats the error messages without the unordered list, which was giving them padding which didn't look correct inside a dialog. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Edit for QA: Removed obsolete changes to CSS. Created attachment 55524 [details] [review] Bug 17147 [Revised] Streamline messages following batch record modification This patch changes the display of informational messages during and after the batch record modification process. Instead of showing a separate dialog for each record modified, messages are now grouped into one dialog. To test, apply the patch and clear your browser cache if necessary. You must have at least one MARC modification template defined. - Go to Tools -> Batch record modification. - Submit a list of biblionumbers which contains at least one number which doesn't exist in your database. - Confirm that warning and success messages are grouped instead of showing in separate dialogs. - Submit a list of biblionumbers using a MARC modification template which contains no actions. Confirm that the resulting error message is correctly formatted. Revision formats the error messages without the unordered list, which was giving them padding which didn't look correct inside a dialog. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Edit for QA: Removed obsolete changes to CSS. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Owen! |