Bug 17185

Summary: Staff client shows "Lists that include this title:" even if item is not in a list
Product: Koha Reporter: Andreas Roussos <arouss1980>
Component: ListsAssignee: Andreas Roussos <arouss1980>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: f.demians, jonathan.druart, julian.maurice, kyle, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14544    
Bug Blocks:    
Attachments: screenshot of staff client showing the error
Bug 17185: Staff client shows "Lists that include this title:" even if item is not in a list
Bug 17185: Staff client shows "Lists that include this title:" even if item is not in a list
Bug 17185: Staff client shows "Lists that include this title:" even if item is not in a list

Description Andreas Roussos 2016-08-24 08:24:16 UTC
Created attachment 54805 [details]
screenshot of staff client showing the error

In the staff client, the text "Lists that include this title:" is always shown, regardless of whether the item is in a list or not (please see attached screenshot).

I've found a way to fix this, and will attach a patch using git bz.

This is my first bug report so please be gentle :-)
Comment 1 Andreas Roussos 2016-08-24 14:13:52 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2016-08-24 14:45:49 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens 2016-08-24 14:53:20 UTC
Created attachment 54834 [details] [review]
Bug 17185: Staff client shows "Lists that include this title:" even if item is not in a list

In the staff client, the text "Lists that include this title:"
is always shown, regardless of whether the item is in a list
or not. This patch fixes that.

Test plan:
1) Log in to staff client.
2) Go to biblio details view:
   /cgi-bin/koha/catalogue/detail.pl?biblionumber=X
   Confirm that "Lists that include this title:" is
   shown even if the item is not in a list.
3) Apply the patch.
4) Repeat step 2. Confirm that the patch works, i.e.
   "Lists that include this title:" is only shown
   for biblios that are actually in a list.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Only applies to non-XSLT view.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Kyle M Hall 2016-09-02 16:50:34 UTC
Pushed to master for 16.11, thanks Andreas!
Comment 5 Frédéric Demians 2016-09-08 20:01:53 UTC
Pushed in 16.05. Will be in 16.05.04.
Comment 6 Julian Maurice 2016-09-16 08:01:33 UTC
Pushed to 3.22.x, will be in 3.22.11