Summary: | Mark REST API dependencies as mandatory in PerlDependencies.pm | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | REST API | Assignee: | Alex Buckley <alexbuckley> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | alexbuckley, gmcharlt, jonathan.druart, kyle, mtj, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14868 | ||
Bug Blocks: | |||
Attachments: |
Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm
Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm |
Description
Katrin Fischer
2016-08-24 19:44:49 UTC
Created attachment 61766 [details] [review] Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm Hi Katrin I am assuming the changes you requested in this bug report were covered by the two minor changes I made in this patch. Test plan: 1. In your terminal view C4/Installer/PerlDependencies.pm and notice that the Mojolicious and swagger2 dependencies which use REST API are optionally required (i.e. have 'required' => '0') 2. Apply this patch 3. View C4/Installer/PerlDependencies.pm again and notice that Mojolicious and swagger2 now have mandatory dependency on REST API (i.e. 'require' => '1') Created attachment 61772 [details] [review] Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm For testing I went in Staff client to Home > About Koha > tab Perl modules and verified that both Mojolicious (6.0) and Swagger2 (0.59) are marked as mandatory. Signed-off-by: Marc Véron <veron@veron.ch> Thx Alex and Marc! Created attachment 62946 [details] [review] Bug 17190 - Marked REST API as mandatory (require = 1) in PerlDependencies.pm For testing I went in Staff client to Home > About Koha > tab Perl modules and verified that both Mojolicious (6.0) and Swagger2 (0.59) are marked as mandatory. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.05, thanks Alex! This patch has been pushed to 16.11.x and will be in 16.11.08. Blocked by Enhancement, skipping for 16.05.x |