Summary: | Confirm message on deleting tag in OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | OPAC | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17191: Confirm message on deleting tag in OPAC
Bug 17191: Confirm message on deleting tag in OPAC Bug 17191: Confirm message on deleting tag in OPAC Bug 17191: Confirm message on deleting tag in OPAC |
Description
Aleisha Amohia
2016-08-24 20:51:35 UTC
Created attachment 54835 [details] [review] Bug 17191: Confirm message on deleting tag in OPAC To test: 1) Log into OPAC, go to your tags 2) Click Delete 3) Confirm message should pop up 4) Ensure clicking Cancel works as expected, ensure clicking OK works as expected Sponsored-by: Catalyst IT Created attachment 54854 [details] [review] Bug 17191: Confirm message on deleting tag in OPAC To test: 1) Log into OPAC, go to your tags 2) Click Delete 3) Confirm message should pop up 4) Ensure clicking Cancel works as expected, ensure clicking OK works as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Please don't add new instances of "onclick." https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events Created attachment 54893 [details] [review] Bug 17191: Confirm message on deleting tag in OPAC Edit: removing use of onclick To test: 1) Log into OPAC, go to your tags 2) Click Delete 3) Confirm message should pop up 4) Ensure clicking Cancel works as expected, ensure clicking OK works as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 55296 [details] [review] Bug 17191: Confirm message on deleting tag in OPAC Edit: removing use of onclick To test: 1) Log into OPAC, go to your tags 2) Click Delete 3) Confirm message should pop up 4) Ensure clicking Cancel works as expected, ensure clicking OK works as expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Aleisha! |