Summary: | When edit record, Button "Z39.50/SRU search" not work | ||
---|---|---|---|
Product: | Koha | Reporter: | Michal Dudzik <dudzikmichal> |
Component: | Cataloging | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | arouss1980, f.demians, jonathan.druart, kyle, m.de.rooy, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17206 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 15859 | ||
Bug Blocks: | |||
Attachments: |
Bug 17194 - When edit record, Button "Z39.50/SRU search" not work
Bug 17194 - When edit record, Button "Z39.50/SRU search" not work Bug 17194 - When edit record, Button "Z39.50/SRU search" not work [PASSED QA] Bug 17194 - When edit record, Button "Z39.50/SRU search" not work |
Description
Michal Dudzik
2016-08-25 10:28:32 UTC
Owen, could you have a look at this one? It has been introduced by bug 15859, the #Frameworks select is now removed and a JS error is raised: TypeError: document.forms.f.Frameworks is undefined var strQuery="&frameworkcode="+document.forms['f'].Frameworks.value; Created attachment 55343 [details] [review] Bug 17194 - When edit record, Button "Z39.50/SRU search" not work Bug 15859 introduced a problem in the basic cataloging editor by removing a form field which the Z39.50 search button tries to use when triggering the search window pop-up. This patch corrects the error by changing where the script looks for the required framework code. To test, apply the patch and got to cataloging. - Edit a record which uses the default framework. - Confirm that the Z39.50/SRU search button works correctly to trigger the pop-up window. - Repeat the test with a record which uses a different framework. Created attachment 55384 [details] [review] Bug 17194 - When edit record, Button "Z39.50/SRU search" not work Bug 15859 introduced a problem in the basic cataloging editor by removing a form field which the Z39.50 search button tries to use when triggering the search window pop-up. This patch corrects the error by changing where the script looks for the required framework code. To test, apply the patch and got to cataloging. - Edit a record which uses the default framework. - Confirm that the Z39.50/SRU search button works correctly to trigger the pop-up window. - Repeat the test with a record which uses a different framework. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Working again, great! Created attachment 55439 [details] [review] Bug 17194 - When edit record, Button "Z39.50/SRU search" not work Bug 15859 introduced a problem in the basic cataloging editor by removing a form field which the Z39.50 search button tries to use when triggering the search window pop-up. This patch corrects the error by changing where the script looks for the required framework code. To test, apply the patch and got to cataloging. - Edit a record which uses the default framework. - Confirm that the Z39.50/SRU search button works correctly to trigger the pop-up window. - Repeat the test with a record which uses a different framework. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Working again, great! Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Patch works fine. Created attachment 55461 [details] [review] [PASSED QA] Bug 17194 - When edit record, Button "Z39.50/SRU search" not work Bug 15859 introduced a problem in the basic cataloging editor by removing a form field which the Z39.50 search button tries to use when triggering the search window pop-up. This patch corrects the error by changing where the script looks for the required framework code. To test, apply the patch and got to cataloging. - Edit a record which uses the default framework. - Confirm that the Z39.50/SRU search button works correctly to trigger the pop-up window. - Repeat the test with a record which uses a different framework. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Working again, great! Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Patch works fine. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Owen! Pushed in 16.05. Will be in 16.05.04. |