|
Description
Vinod
2016-08-29 11:47:44 UTC
While record number is a bad idea, biblionumber, would be okay. If you were to add to a list by biblionumber, if that record has multiple items under it, does it add all items with that biblionumber or just the first item? (In reply to Aleisha Amohia from comment #2) > If you were to add to a list by biblionumber, if that record has multiple > items under it, does it add all items with that biblionumber or just the > first item? A list contains of biblios, not items. Created attachment 62431 [details] [review] Bug 17214: Add records to lists by biblionumber To test: 1) Apply patch and go to Lists 2) Click on an existing list or create a new list 3) Add items by barcode, confirm this functionality still works 4) Trigger error messages (adding duplicate barcodes, barcodes that don't exist) to confirm they still show as appropriate 5) Test adding by biblionumber, confirm this works as expected 6) Trigger error messages (adding duplicate biblionumbers, biblionumbers that don't exist). Confirm wording is appropriate in messages. 7) Add both barcodes and biblionumbers at the same time, confirm this works as expected Sponsored-by: Catalyst IT Patch tested with a sandbox, by Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Created attachment 64567 [details] [review] Bug 17214: Add records to lists by biblionumber To test: 1) Apply patch and go to Lists 2) Click on an existing list or create a new list 3) Add items by barcode, confirm this functionality still works 4) Trigger error messages (adding duplicate barcodes, barcodes that don't exist) to confirm they still show as appropriate 5) Test adding by biblionumber, confirm this works as expected 6) Trigger error messages (adding duplicate biblionumbers, biblionumbers that don't exist). Confirm wording is appropriate in messages. 7) Add both barcodes and biblionumbers at the same time, confirm this works as expected Sponsored-by: Catalyst IT Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Patch tested with a sandbox, by Harold <harold.sabanal@gmail.com> Created attachment 64568 [details] [review] Bug 17214: Add records to lists by biblionumber To test: 1) Apply patch and go to Lists 2) Click on an existing list or create a new list 3) Add items by barcode, confirm this functionality still works 4) Trigger error messages (adding duplicate barcodes, barcodes that don't exist) to confirm they still show as appropriate 5) Test adding by biblionumber, confirm this works as expected 6) Trigger error messages (adding duplicate biblionumbers, biblionumbers that don't exist). Confirm wording is appropriate in messages. 7) Add both barcodes and biblionumbers at the same time, confirm this works as expected Sponsored-by: Catalyst IT Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Harold <harold.sabanal@gmail.com> Patch tested with a sandbox, by macon lauren KohaCon2017 <caballeromaricon@gmail.com> Created attachment 64569 [details] [review] Bug 17214: Add records to lists by biblionumber To test: 1) Apply patch and go to Lists 2) Click on an existing list or create a new list 3) Add items by barcode, confirm this functionality still works 4) Trigger error messages (adding duplicate barcodes, barcodes that don't exist) to confirm they still show as appropriate 5) Test adding by biblionumber, confirm this works as expected 6) Trigger error messages (adding duplicate biblionumbers, biblionumbers that don't exist). Confirm wording is appropriate in messages. 7) Add both barcodes and biblionumbers at the same time, confirm this works as expected Sponsored-by: Catalyst IT Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Harold <harold.sabanal@gmail.com> Signed-off-by: macon lauren KohaCon2017 <caballeromaricon@gmail.com> QA: Looking here now. Bug 18260 has been pushed in the meantime and it removed GetBiblio. Internal server error: Undefined subroutine &CGI::Compile::ROOT::usr_share_koha_masterclone_virtualshelves_shelves_2epl::GetBiblio called at /usr/share/koha/masterclone/virtualshelves/shelves.pl line 178. Created attachment 66828 [details] [review] Bug 17214: [FOLLOW-UP] Using Koha::Biblios instead of GetBiblio Ready to test Created attachment 67815 [details] [review] Bug 17214: Add records to lists by biblionumber To test: 1) Apply patch and go to Lists 2) Click on an existing list or create a new list 3) Add items by barcode, confirm this functionality still works 4) Trigger error messages (adding duplicate barcodes, barcodes that don't exist) to confirm they still show as appropriate 5) Test adding by biblionumber, confirm this works as expected 6) Trigger error messages (adding duplicate biblionumbers, biblionumbers that don't exist). Confirm wording is appropriate in messages. 7) Add both barcodes and biblionumbers at the same time, confirm this works as expected Sponsored-by: Catalyst IT Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Harold <harold.sabanal@gmail.com> Signed-off-by: macon lauren KohaCon2017 <caballeromaricon@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 67816 [details] [review] Bug 17214: [FOLLOW-UP] Using Koha::Biblios instead of GetBiblio Ready to test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice! QA: Looking here now Created attachment 68657 [details] [review] Bug 17214: Add records to lists by biblionumber To test: 1) Apply patch and go to Lists 2) Click on an existing list or create a new list 3) Add items by barcode, confirm this functionality still works 4) Trigger error messages (adding duplicate barcodes, barcodes that don't exist) to confirm they still show as appropriate 5) Test adding by biblionumber, confirm this works as expected 6) Trigger error messages (adding duplicate biblionumbers, biblionumbers that don't exist). Confirm wording is appropriate in messages. 7) Add both barcodes and biblionumbers at the same time, confirm this works as expected Sponsored-by: Catalyst IT Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Harold <harold.sabanal@gmail.com> Signed-off-by: macon lauren KohaCon2017 <caballeromaricon@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 17214: [FOLLOW-UP] Using Koha::Biblios instead of GetBiblio Ready to test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 68658 [details] [review] Bug 17214: Add records to lists by biblionumber To test: 1) Apply patch and go to Lists 2) Click on an existing list or create a new list 3) Add items by barcode, confirm this functionality still works 4) Trigger error messages (adding duplicate barcodes, barcodes that don't exist) to confirm they still show as appropriate 5) Test adding by biblionumber, confirm this works as expected 6) Trigger error messages (adding duplicate biblionumbers, biblionumbers that don't exist). Confirm wording is appropriate in messages. 7) Add both barcodes and biblionumbers at the same time, confirm this works as expected Sponsored-by: Catalyst IT Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> Signed-off-by: Harold <harold.sabanal@gmail.com> Signed-off-by: macon lauren KohaCon2017 <caballeromaricon@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 17214: [FOLLOW-UP] Using Koha::Biblios instead of GetBiblio Ready to test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 68659 [details] [review] Bug 17214: (QA follow-up) Print error message too in fallback case If the error code is not known or empty, provide the message too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested this by adding a die on shelves.pl line 180 (my $added = eval ..) QA Comment:
No blocker, but having some doubts on this line:
if ($@) {
push @messages, { bibnum => $biblionumber, type => 'alert', code => ref($@), msg => $@ };
For a regular die ref($@) is empty string, so code will be empty.
If $@ is an object, the template only checks DBIx::Class::Exception.
But shelf store might raise a few Koha::Exceptions too..
Added a follow-up that at least adds message when code is empty.
And yet another non-blocking comment/design issue: If you add quite a number of biblio numbers, you will add an alert for each added record. They could easily make me ignore the warnings on errors. You could add an alert to tell me how many records were added instead; something for another report? Pushed to master for 17.11, thanks to everybody involved! |