Bug 17226

Summary: Improve AUTOLOAD of Koha::Object
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: brendan, mtj
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 17091    
Bug Blocks: 14899, 17251    
Attachments: Bug 17226: Improve Koha::Object's AUTOLOAD method
Bug 17226: Make Koha::Object->get_column available
Bug 17226: Improve Koha::Object's AUTOLOAD method
Bug 17226: Make Koha::Object->get_column available
Bug 17226: Improve Koha::Object's AUTOLOAD method
Bug 17226: Make Koha::Object->get_column available
Bug 17226 - Fix unit tests

Description Jonathan Druart 2016-08-30 15:13:00 UTC
Following the path of bug 17091, Koha::Object needs to AUTOLOAD the methods provided by DBIX::Class.
We already use in_storage, id and is_changed, but others are coming!
Comment 1 Jonathan Druart 2016-08-30 15:16:37 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2016-08-30 15:24:24 UTC Comment hidden (obsolete)
Comment 3 Claire Gravely 2016-09-05 21:19:02 UTC
Created attachment 55203 [details] [review]
Bug 17226: Improve Koha::Object's AUTOLOAD method

Following the path of bug 17091, Koha::Object needs to AUTOLOAD the
methods provided by DBIX::Class.
We already use in_storage, id and is_changed, but others are coming!

Test plan:
  prove t/db_dependent/Koha/Object.t
should return green

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Comment 4 Claire Gravely 2016-09-05 21:24:00 UTC
Created attachment 55204 [details] [review]
Bug 17226: Make Koha::Object->get_column available

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Comment 5 Kyle M Hall (khall) 2016-10-11 09:00:25 UTC
Created attachment 56138 [details] [review]
Bug 17226: Improve Koha::Object's AUTOLOAD method

Following the path of bug 17091, Koha::Object needs to AUTOLOAD the
methods provided by DBIX::Class.
We already use in_storage, id and is_changed, but others are coming!

Test plan:
  prove t/db_dependent/Koha/Object.t
should return green

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Comment 6 Kyle M Hall (khall) 2016-10-11 09:00:48 UTC
Created attachment 56139 [details] [review]
Bug 17226: Make Koha::Object->get_column available

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Comment 7 Kyle M Hall (khall) 2016-10-11 09:00:57 UTC
Created attachment 56140 [details] [review]
Bug 17226 - Fix unit tests
Comment 8 Brendan Gallagher 2016-10-12 12:01:51 UTC
Pushed to Master - Should be in the November 2016 release. Thanks!