| Summary: | Standardize on "Patron categories" when referring to patron category | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | arouss1980, kyle, mtj, sandboxes, veron |
| Version: | unspecified | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 16298 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 17290 - Standardize on "Patron Categories"
Bug 17290 - Standardize on "Patron Categories" Bug 17290 - Standardize on "Patron Categories" Bug 17290 - Standardize on "Patron Categories" |
||
|
Description
Katrin Fischer
2016-09-10 09:23:04 UTC
I could be wrong, but I think there's a few more occurrences to update if you grep for "patron type" (i.e. in the singular). Yep, checking singular too is a good idea. Created attachment 59119 [details] [review] Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch Comment on attachment 59119 [details] [review] Bug 17290 - Standardize on "Patron Categories" Review of attachment 59119 [details] [review]: ----------------------------------------------------------------- Hey Grace, overall this reads great already - can you please take a look at the notes I made and provide a new patch or a follow-up? Thx! ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +1,1 @@ > +% USE Koha %] I think this was an accidental change, can you please fix and resubmit? ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/item_circulation_alerts.tt @@ +16,4 @@ > <li>To set preferences for all libraries, keep the menu set to 'Default'</li> > </ul> > </li> > + <li>By default all item types and all patrons are notified of check ins and check outs. To change this, click on the item/patron category combination that you would like to stop notices for.</li> We have patron categories and item types in Koha, so maybe it would read a little better as: item type/patron category ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/members/boraccount.tt @@ +10,4 @@ > > <ul> > <li>Fines will be charged based on your Circulation & Fines Rules</li> > + <li>Hold fees will be charged based on the rules you set in the Patron Categories & Categories administration area</li> I think the original read a little oddly as we don't have a section in administration that reads like the help suggests. My suggestion is to write something like: Hold fees will be charged based on the rules you set for the patron category in administration. Created attachment 59176 [details] [review] Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch Comment on attachment 59176 [details] [review] Bug 17290 - Standardize on "Patron Categories" Review of attachment 59176 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/categorie.tt @@ +2,4 @@ > > <h1>Patron Categories</h1> > > +<p>Patron categories allow you to organize your patrons into different roles, age groups, and patron categories.</p> Isn't "patron categories." at the end over kill? Patron categories allow you to organize your patrons into different roles, age groups, and categories. Patch tested with a sandbox, by Cédric Vita <cedric.vita@dracenie.com> Created attachment 61386 [details] [review] Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch Signed-off-by: Cédric Vita <cedric.vita@dracenie.com> Signed-off-by: Cédric Vita <cedric.vita@dracenie.com> Created attachment 61403 [details] [review] Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch Signed-off-by: Cédric Vita <cedric.vita@dracenie.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Grace! This patch has been pushed to 16.11.x and will be in 16.11.07. Pushed to 16.05.x, for 16.05.12 release |