| Summary: | Date due shows incorrect time on SCO. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Barton Chittenden <barton> |
| Component: | Self checkout | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, kyle, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14595 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14016 |
||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 17299: Display date due correctly on SCO
Bug 17299: Display date due correctly on SCO Bug 17299: Display date due correctly on SCO |
||
Created attachment 55553 [details] [review] Bug 17299: Display date due correctly on SCO Unless it's an hourly loan, date due should not display the time part (23:59). Because of bad code in GetPendingIssues, date_due is replaced with a DateTime object and is copied into date_due_sql. We need to use this date_due_sql to correctly display the date due in the sco module. Test plan: 1/ Enable WebBasedSelfCheck syspref 2/ Check out an item to User A -- Do not use an hourly loan. 3/ Log in to Koha self check ( {OPAC URL}/cgi-bin/koha/sco/sco-main.pl). 4/ Enter User A's cardnumber. Without this patch, checkouts are MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H) With this patch applied, only the date is displayed Created attachment 55563 [details] [review] Bug 17299: Display date due correctly on SCO Unless it's an hourly loan, date due should not display the time part (23:59). Because of bad code in GetPendingIssues, date_due is replaced with a DateTime object and is copied into date_due_sql. We need to use this date_due_sql to correctly display the date due in the sco module. Test plan: 1/ Enable WebBasedSelfCheck syspref 2/ Check out an item to User A -- Do not use an hourly loan. 3/ Log in to Koha self check ( {OPAC URL}/cgi-bin/koha/sco/sco-main.pl). 4/ Enter User A's cardnumber. Without this patch, checkouts are MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H) With this patch applied, only the date is displayed Followed test plan, works as expected. Signed-off-by: Marc <veron@veron.ch> Created attachment 55584 [details] [review] Bug 17299: Display date due correctly on SCO Unless it's an hourly loan, date due should not display the time part (23:59). Because of bad code in GetPendingIssues, date_due is replaced with a DateTime object and is copied into date_due_sql. We need to use this date_due_sql to correctly display the date due in the sco module. Test plan: 1/ Enable WebBasedSelfCheck syspref 2/ Check out an item to User A -- Do not use an hourly loan. 3/ Log in to Koha self check ( {OPAC URL}/cgi-bin/koha/sco/sco-main.pl). 4/ Enter User A's cardnumber. Without this patch, checkouts are MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H) With this patch applied, only the date is displayed Followed test plan, works as expected. Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 16.11, thanks Jonathan! (In reply to Kyle M Hall from comment #4) > Pushed to master for 16.11, thanks Jonathan! I would definitely like to see this back-ported -- as far as I can tell, it's a one line fix with no dependencies, and the bug causes Koha to give incorrect information to patrons. |
For non-hourly loans, date due will by YYYY-MM-DD 23:59:00 Assuming date format MM/DD/YYYY, the date due under the self-checkout should appear as MM/DD/YYYY 11:59:00 PM (Timeformat: 12 hour) or MM/DD/YYYY 23:59:00 (Timeformat 24H). Instead it is showing as either MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H) Steps to reproduce: 1/ Enable WebBasedSelfCheck syspref 2/ Check out an item to User A -- Do not use an hourly loan. 3/ Log in to Koha self check ( {OPAC URL}/cgi-bin/koha/sco/sco-main.pl). 4/ Enter User A's cardnumber. See that Checkouts are MM/DD/YYYY 12:00 AM (Timeformat: 12 hour) or MM/DD/YYYY 00:00 (Timeformat: 24H)