| Summary: | Typo in members-toolbar.inc / moremember-brief.tt / moremember.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andreas Roussos <arouss1980> |
| Component: | Templates | Assignee: | Andreas Roussos <arouss1980> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | f.demians, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 17312 - Typo in members-toolbar.inc / moremember-brief.tt / moremember.tt
Bug 17312 - Typo in members-toolbar.inc / moremember-brief.tt / moremember.tt [PASSED QA] Bug 17312 - Typo in members-toolbar.inc / moremember-brief.tt / moremember.tt |
||
|
Description
Andreas Roussos
2016-09-17 15:58:39 UTC
Created attachment 55631 [details] [review] Bug 17312 - Typo in members-toolbar.inc / moremember-brief.tt / moremember.tt The following three templates are using [% guarantorborrowernumber %] while they should be using [% guarantor.borrowernumber %]: members/members-toolbar.inc members/moremember-brief.tt members/moremember.tt This doesn't result in any breakage; just a couple of 'Edit' links that do not pass the guarantorid in the URL, and one case where guarantor information is not shown in the staff client. This patch fixes that. Test plan: 0) [PREREQUISITE] Create a patron with a guarantor if you don't have one. 1) Go to Home > Patrons and search for a patron that has a guarantor. In the Details page for that patron, the 'Edit' link in the toolbar does not pass the guarantor's id in the URL (...&guarantorid=&...). 2) In the same page, the 'Edit' link under the patrons name (immediately under 'Guarantor') again does not include the guarantor id in the URL. 3) Go to Home > Patrons and click on 'New patron'. Pick any category from the drop down menu. Enter the Surname, First name, and Date of birth of the patron you used in step 1). This triggers the 'Duplicate patron record?' warning -- click on 'View existing record' and notice how the guarantor information is missing. 4) Apply the patch. 5) Repeat steps 1), 2), and 3) above. The URLs are fixed and patron info is showing. Created attachment 55789 [details] [review] Bug 17312 - Typo in members-toolbar.inc / moremember-brief.tt / moremember.tt The following three templates are using [% guarantorborrowernumber %] while they should be using [% guarantor.borrowernumber %]: members/members-toolbar.inc members/moremember-brief.tt members/moremember.tt This doesn't result in any breakage; just a couple of 'Edit' links that do not pass the guarantorid in the URL, and one case where guarantor information is not shown in the staff client. This patch fixes that. Test plan: 0) [PREREQUISITE] Create a patron with a guarantor if you don't have one. 1) Go to Home > Patrons and search for a patron that has a guarantor. In the Details page for that patron, the 'Edit' link in the toolbar does not pass the guarantor's id in the URL (...&guarantorid=&...). 2) In the same page, the 'Edit' link under the patrons name (immediately under 'Guarantor') again does not include the guarantor id in the URL. 3) Go to Home > Patrons and click on 'New patron'. Pick any category from the drop down menu. Enter the Surname, First name, and Date of birth of the patron you used in step 1). This triggers the 'Duplicate patron record?' warning -- click on 'View existing record' and notice how the guarantor information is missing. 4) Apply the patch. 5) Repeat steps 1), 2), and 3) above. The URLs are fixed and patron info is showing. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 55792 [details] [review] [PASSED QA] Bug 17312 - Typo in members-toolbar.inc / moremember-brief.tt / moremember.tt The following three templates are using [% guarantorborrowernumber %] while they should be using [% guarantor.borrowernumber %]: members/members-toolbar.inc members/moremember-brief.tt members/moremember.tt This doesn't result in any breakage; just a couple of 'Edit' links that do not pass the guarantorid in the URL, and one case where guarantor information is not shown in the staff client. This patch fixes that. Test plan: 0) [PREREQUISITE] Create a patron with a guarantor if you don't have one. 1) Go to Home > Patrons and search for a patron that has a guarantor. In the Details page for that patron, the 'Edit' link in the toolbar does not pass the guarantor's id in the URL (...&guarantorid=&...). 2) In the same page, the 'Edit' link under the patrons name (immediately under 'Guarantor') again does not include the guarantor id in the URL. 3) Go to Home > Patrons and click on 'New patron'. Pick any category from the drop down menu. Enter the Surname, First name, and Date of birth of the patron you used in step 1). This triggers the 'Duplicate patron record?' warning -- click on 'View existing record' and notice how the guarantor information is missing. 4) Apply the patch. 5) Repeat steps 1), 2), and 3) above. The URLs are fixed and patron info is showing. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Andreas! Pushed in 16.05. Will be in 16.05.05. |