Bug 17331

Summary: Show holding branch in holds awaiting pickup report
Product: Koha Reporter: Nick Clemens <nick>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: frederic, gmcharlt, hector.hecaxmmx, katrin.fischer, kyle.m.hall, kyle
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 17331 - Show holding branch in holds awaiting pickup report
[SIGNED-OFF]Bug 17331: Show holding branch in holds awaiting pickup report
[PASSED QA] Bug 17331 - Show holding branch in holds awaiting pickup report

Description Nick Clemens 2016-09-23 10:39:05 UTC
Currently waitingreserves.pl shows an items homebranch plus callnumber as 'location'

When viewing all libraries this information is confusing and on the 'holds over' tab the location is missing a <br /> tag so the info can appear oddly.
Comment 1 Nick Clemens 2016-09-23 10:43:41 UTC
Created attachment 55767 [details] [review]
Bug 17331 - Show holding branch in holds awaiting pickup report

This patch adds a holdingbranch column to waitingreseves.tt and
separates 'Location' into Home branch and callnumber columns

To test:
1 - Have some holds waiting and holds over
2 - View the report before the patch
3 - Note that location contains homebranch and call number
4 - View the report after the patch
5 - Note the new columns
6 - Ensure data is correct and no info has been lost
Comment 2 Héctor Eduardo Castro Avalos 2016-09-23 14:02:28 UTC
Created attachment 55774 [details] [review]
[SIGNED-OFF]Bug 17331: Show holding branch in holds awaiting pickup report

This patch adds a holdingbranch column to waitingreseves.tt and
separates 'Location' into Home branch and callnumber columns

To test:
1 - Have some holds waiting and holds over
2 - View the report before the patch
3 - Note that location contains homebranch and call number
4 - View the report after the patch
5 - Note the new columns
6 - Ensure data is correct and no info has been lost

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised
Comment 3 Katrin Fischer 2016-09-25 12:19:52 UTC
Fixed some capitalization issues.
Comment 4 Katrin Fischer 2016-09-25 12:21:40 UTC
Created attachment 55795 [details] [review]
[PASSED QA] Bug 17331 - Show holding branch in holds awaiting pickup report

This patch adds a holdingbranch column to waitingreseves.tt and
separates 'Location' into Home branch and callnumber columns

To test:
1 - Have some holds waiting and holds over
2 - View the report before the patch
3 - Note that location contains homebranch and call number
4 - View the report after the patch
5 - Note the new columns
6 - Ensure data is correct and no info has been lost

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Fixed 2 capitalization issues.
Comment 5 Kyle M Hall 2016-09-27 11:32:37 UTC
Pushed to master for 16.11, thanks Nick!
Comment 6 Frédéric Demians 2016-09-30 09:14:24 UTC
Pushed in 16.05. Will be in 16.05.05.