Summary: | Memcached configuration missing in koha-conf* files | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | f.demians, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 11921 | ||
Bug Blocks: | 17336 | ||
Attachments: |
Bug 17332: Include memcached configuration in koha-conf files
Bug 17332: Remove memcached config from apache files Bug 17332: Include memcached configuration in koha-conf files Bug 17332: Remove memcached config from apache files Bug 17332: Include memcached configuration in koha-conf files Bug 17332: Remove memcached config from apache files |
Description
Tomás Cohen Arazi (tcohen)
2016-09-23 14:19:49 UTC
Created attachment 55776 [details] [review] Bug 17332: Include memcached configuration in koha-conf files This patch introduces the memcached_servers and memcached_namespace configuration entries as expected by 11921. Note: better test this one and the followup together to ease the process. To test: - Do a source Koha install (dev, standard, single) => SUCCESS: The resulting koha-conf.xml file includes the memcached_* entries which are filled with the right values. - In kohadevbox (packages setup): - Replace /etc/koha/koha-conf-site.xml.in with the one from this patch - Create a new koha instance => SUCCESS: The instance's koha-conf.xml includes the relevant entries - Sign off Created attachment 55777 [details] [review] Bug 17332: Remove memcached config from apache files This patch removes Memcached configurations from the shipped apache files. Note: testing is not actually needed for this patch, as it is really trivial. But I include testing steps, just in case QA members require it. To test: - Apply the patch - Do a (standard/dev/single) Koah install => SUCCESS: Verify the resulting koha-httpd.conf file doens't include memcached data - Have a packages install - Replace * /etc/koha/apache-site-https.conf.in * /etc/koha/apache-site.conf.in with the ones from this patch - Create an instance => SUCCESS: The apache configuration doesn't include memcached configurations - Sign off :-D Created attachment 55784 [details] [review] Bug 17332: Include memcached configuration in koha-conf files This patch introduces the memcached_servers and memcached_namespace configuration entries as expected by 11921. Note: better test this one and the followup together to ease the process. To test: - Do a source Koha install (dev, standard, single) => SUCCESS: The resulting koha-conf.xml file includes the memcached_* entries which are filled with the right values. - In kohadevbox (packages setup): - Replace /etc/koha/koha-conf-site.xml.in with the one from this patch - Create a new koha instance => SUCCESS: The instance's koha-conf.xml includes the relevant entries - Sign off Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 55785 [details] [review] Bug 17332: Remove memcached config from apache files This patch removes Memcached configurations from the shipped apache files. Note: testing is not actually needed for this patch, as it is really trivial. But I include testing steps, just in case QA members require it. To test: - Apply the patch - Do a (standard/dev/single) Koah install => SUCCESS: Verify the resulting koha-httpd.conf file doens't include memcached data - Have a packages install - Replace * /etc/koha/apache-site-https.conf.in * /etc/koha/apache-site.conf.in with the ones from this patch - Create an instance => SUCCESS: The apache configuration doesn't include memcached configurations - Sign off :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 55828 [details] [review] Bug 17332: Include memcached configuration in koha-conf files This patch introduces the memcached_servers and memcached_namespace configuration entries as expected by 11921. Note: better test this one and the followup together to ease the process. To test: - Do a source Koha install (dev, standard, single) => SUCCESS: The resulting koha-conf.xml file includes the memcached_* entries which are filled with the right values. - In kohadevbox (packages setup): - Replace /etc/koha/koha-conf-site.xml.in with the one from this patch - Create a new koha instance => SUCCESS: The instance's koha-conf.xml includes the relevant entries - Sign off Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 55829 [details] [review] Bug 17332: Remove memcached config from apache files This patch removes Memcached configurations from the shipped apache files. Note: testing is not actually needed for this patch, as it is really trivial. But I include testing steps, just in case QA members require it. To test: - Apply the patch - Do a (standard/dev/single) Koah install => SUCCESS: Verify the resulting koha-httpd.conf file doens't include memcached data - Have a packages install - Replace * /etc/koha/apache-site-https.conf.in * /etc/koha/apache-site.conf.in with the ones from this patch - Create an instance => SUCCESS: The apache configuration doesn't include memcached configurations - Sign off :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 16.11, thanks Tomas! |