Summary: | 'Renew' tab should ignore whitespace at begining and end of barcode | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Circulation | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kohadevinim, kyle.m.hall, lucas, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17347: Ignore whitespace before and after on renewing
Bug 17347: Ignore whitespace before and after on renewing Bug 17347: Ignore whitespace before and after on renewing Bug 17347: Ignore whitespace before and after on renewing |
Description
Katrin Fischer
2016-09-25 13:06:45 UTC
Created attachment 83918 [details] [review] Bug 17347: Ignore whitespace before and after on renewing When an item is checked out, Koha ignores whitespace at the beginning and the end of the entered barcode. This makes life easier, if a barcode is C&P from another page. This patch makes the renewal page behave the same. To test: - Checkout an item - Renew the item from the renew tab or renewal page entering the barcode with leading and trailing whitespace - "Barcode not found" - Apply patch - Try again - Barcode should be found now Created attachment 83988 [details] [review] Bug 17347: Ignore whitespace before and after on renewing When an item is checked out, Koha ignores whitespace at the beginning and the end of the entered barcode. This makes life easier, if a barcode is C&P from another page. This patch makes the renewal page behave the same. To test: - Checkout an item - Renew the item from the renew tab or renewal page entering the barcode with leading and trailing whitespace - "Barcode not found" - Apply patch - Try again - Barcode should be found now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 84151 [details] [review] Bug 17347: Ignore whitespace before and after on renewing When an item is checked out, Koha ignores whitespace at the beginning and the end of the entered barcode. This makes life easier, if a barcode is C&P from another page. This patch makes the renewal page behave the same. To test: - Checkout an item - Renew the item from the renew tab or renewal page entering the barcode with leading and trailing whitespace - "Barcode not found" - Apply patch - Try again - Barcode should be found now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Hi Katrin, Good patch, Thanks. We tried to give a blank in the box, then press Tab, go back to the box again and paste the barcode, in that case it did not recognize the barcode since there is a Tab. Thanks Devinim Koha Team Hi Devinim, could you test the same in circ please? I used the same regex that is used there. I was aiming to make them behave the same. Created attachment 84882 [details] [review] Bug 17347: Ignore whitespace before and after on renewing When an item is checked out, Koha ignores whitespace at the beginning and the end of the entered barcode. This makes life easier, if a barcode is C&P from another page. This patch makes the renewal page behave the same. To test: - Checkout an item - Renew the item from the renew tab or renewal page entering the barcode with leading and trailing whitespace - "Barcode not found" - Apply patch - Try again - Barcode should be found now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Another trivial but helpful patch which introduces no regressions.. Passing QA Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 backported to 18.05.x for 18.05.09 Pushed to 17.11.x for 17.11.15 |