Summary: | Add phone number column to checkout search | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, dcook, gmcharlt, jonathan.druart, josef.moravec, kyle.m.hall, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36614 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement adds patrons phone numbers to the checkout search results. It is hidden by default and is displayed by configuring the columns for circulation tables (Administration > Additional parameters > Configure columns > Circulation > table_borrowers > untick the phone column).
|
Version(s) released in: | |
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 22215, 30068 | ||
Attachments: |
Bug 17353 - Add phone number column to checkout search
Bug 17353 - Add phone number column to checkout search Bug 17353 - Add phone number column to checkout search Bug 17353: Add phone number column to checkout search Bug 17353: (follow-up) Adjust config variable for moremember.tt too Bug 17353: Add phone number column to checkout search Bug 17353: (follow-up) Adjust config variable for moremember.tt too |
Description
Nick Clemens (kidclamp)
2016-09-26 17:42:59 UTC
Created attachment 55824 [details] [review] Bug 17353 - Add phone number column to checkout search This patch adds borrowers.phone as 'Primary phone' in the checkout search results. To test: 1 - Perform a checkout search 2 - Note phone is not displayed 3 - Apply patch 4 - Note phone displays 5 - Ensure page functions as before patch Created attachment 55831 [details] [review] Bug 17353 - Add phone number column to checkout search This patch adds borrowers.phone as 'Primary phone' in the checkout search results. To test: 1 - Perform a checkout search 2 - Note phone is not displayed 3 - Apply patch 4 - Note phone displays 5 - Ensure page functions as before patch Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Is it a very useful information to show for everybody? Would not it better to hide it by default (and use the columns configuration tool)? I like the idea of using the Columns Configuration tool here. I also wondered about the phone number displaying here - can you explain why the library/libraries have asked for it? I notice we don't show the phone number in the more verbose patron search. Created attachment 83720 [details] [review] Bug 17353 - Add phone number column to checkout search This patch adds borrowers.phone as 'Primary phone' in the checkout search results. It also ads the table to columns configuration To test: 1 - Perform a checkout search 2 - Note phone is not displayed 3 - Apply patch 4 - Note phone does not display 5 - Visit columns configuration 6 - Unhide the 'phone' column 7 - Note phone displays 8 - Ensure page functions as before patch Created attachment 83743 [details] [review] Bug 17353: Add phone number column to checkout search This patch adds borrowers.phone as 'Primary phone' in the checkout search results. It also ads the table to columns configuration To test: 1 - Perform a checkout search 2 - Note phone is not displayed 3 - Apply patch 4 - Note phone does not display 5 - Visit columns configuration 6 - Unhide the 'phone' column 7 - Note phone displays 8 - Ensure page functions as before patch Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 83775 [details] [review] Bug 17353: (follow-up) Adjust config variable for moremember.tt too Small favor: can we please use a clearer name for the table, that is consistent with the others? This uses: table_borrowers. Most use *-table and hyphens. Also... patron vs. borrower. Created attachment 83858 [details] [review] Bug 17353: Add phone number column to checkout search This patch adds borrowers.phone as 'Primary phone' in the checkout search results. It also ads the table to columns configuration To test: 1 - Perform a checkout search 2 - Note phone is not displayed 3 - Apply patch 4 - Note phone does not display 5 - Visit columns configuration 6 - Unhide the 'phone' column 7 - Note phone displays 8 - Ensure page functions as before patch Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 83859 [details] [review] Bug 17353: (follow-up) Adjust config variable for moremember.tt too Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> see comment 8 Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series. |