Summary: | plugins tests are broken - KitchenSinkPlugin | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 7804 | ||
Bug Blocks: | |||
Attachments: |
Bug 17368: Update KitchenSinkPlugin.kpz
Bug 17368: Update KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz |
Description
Jonathan Druart
2016-09-28 13:44:35 UTC
Created attachment 55888 [details] [review] Bug 17368: Update KitchenSinkPlugin.kpz The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test if our system plugin is ok. Currently this plugin is broken because it uses subroutines which have been removed: GetBranchesLoop and GetBorrowercategoryList A PR has just been made (https://github.com/bywatersolutions/koha-plugin-kitchen-sink/pull/2) This kpz has been generated on top of the following commit: commit 5d109c9e1a5d3d314b346a529f2059176778d05a Adapt code for versions > 16.06.00.018 2 subroutines has been removed and the plugin does not work anymore. with: % zip -r KitchenSinkPlugin.kpz Koha Test plan: prove t/db_dependent/plugins.t should now be happy Created attachment 56287 [details] [review] Bug 17368: Update KitchenSinkPlugin.kpz The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test if our system plugin is ok. Currently this plugin is broken because it uses subroutines which have been removed: GetBranchesLoop and GetBorrowercategoryList A PR has just been made (https://github.com/bywatersolutions/koha-plugin-kitchen-sink/pull/2) This kpz has been generated on top of the following commit: commit 5d109c9e1a5d3d314b346a529f2059176778d05a Adapt code for versions > 16.06.00.018 2 subroutines has been removed and the plugin does not work anymore. with: % zip -r KitchenSinkPlugin.kpz Koha Test plan: prove t/db_dependent/plugins.t should now be happy Signed-off-by: Magnus Enger <magnus@libriotech.no> prove t/db_dependent/Plugins.t fails before the patch and passes nicely after applying the patch. Created attachment 56690 [details] [review] Bug 17368: Update KitchenSinkPlugin.kpz The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test if our system plugin is ok. Currently this plugin is broken because it uses subroutines which have been removed: GetBranchesLoop and GetBorrowercategoryList A PR has just been made (https://github.com/bywatersolutions/koha-plugin-kitchen-sink/pull/2) This kpz has been generated on top of the following commit: commit 5d109c9e1a5d3d314b346a529f2059176778d05a Adapt code for versions > 16.06.00.018 2 subroutines has been removed and the plugin does not work anymore. with: % zip -r KitchenSinkPlugin.kpz Koha Test plan: prove t/db_dependent/plugins.t should now be happy Signed-off-by: Magnus Enger <magnus@libriotech.no> prove t/db_dependent/Plugins.t fails before the patch and passes nicely after applying the patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 16.11, thanks Jonathan! Pushed in 16.05. Will be in 16.05.05. |