|
Description
Jonathan Druart
2016-09-29 11:00:26 UTC
I don't not plan to work on this. Created attachment 56317 [details] [review] Bug 17373 - Elasticsearch - Authority mappings for UNIMARC - patch1 This patch starts the UNIMARC mapping for ES. It is needed to test. More patches will come. Please provide a test plan. Hey Frido, if you provide a test plan, we will sign your patch :). We currently are testing elasticsearch for the BULAC. Created attachment 72719 [details] [review] Bug 17373 - Add mappings for unimarc authorities - Match index Created attachment 72779 [details]
Sample of 5 israeli authors in unimarc
you can search for :
Oz
Shalev
Appelfeld
עוז
שלו
אפלפלד
Created attachment 72780 [details] [review] Bug 17373 - Elasticsearch - Authority mappings for UNIMARC - patch1 This patch starts the UNIMARC mapping for ES. It is needed to test. More patches will come. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Created attachment 72781 [details] [review] Bug 17373 - Add mappings for unimarc authorities - Match index Test plan: 1. apply patches 2. switch SearchEngine syspref to ElasticSearch 3. load new mapping (admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1) 4. load some unimarc authorities like the sample attached to bug 17373 5. reindex authorities (./misc/search_tools/rebuild_elastic_search.pl -d -a -v) 6. search entire notice for shalev or שלב 7. you should find stuff Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Created attachment 72798 [details] [review] Bug 17373 - Add mappings for unimarc authorities - Match index Test plan: 1. apply patches 2. switch SearchEngine syspref to ElasticSearch 3. load new mapping (admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1) 4. load some unimarc authorities like the sample attached to bug 17373 5. reindex authorities (./misc/search_tools/rebuild_elastic_search.pl -d -a -v) 6. search entire notice for shalev or שלו 7. you should find stuff Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Created attachment 73461 [details] [review] Bug 17373 - Elasticsearch - Authority mappings for UNIMARC - patch1 This patch starts the UNIMARC mapping for ES. It is needed to test. More patches will come. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 73462 [details] [review] Bug 17373 - Add mappings for unimarc authorities - Match index Test plan: 1. apply patches 2. switch SearchEngine syspref to ElasticSearch 3. load new mapping (admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1) 4. load some unimarc authorities like the sample attached to bug 17373 5. reindex authorities (./misc/search_tools/rebuild_elastic_search.pl -d -a -v) 6. search entire notice for shalev or שלו 7. you should find stuff Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> I did not test live, however, the mappings code make sense, the file still loads, if they say it is correct for UNIMARC I believe them :-) Please fix patches' author (name and email). Created attachment 73674 [details] [review] Bug 17373 - Elasticsearch - Authority mappings for UNIMARC - patch1 This patch starts the UNIMARC mapping for ES. It is needed to test. More patches will come. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 73675 [details] [review] Bug 17373 - Add mappings for unimarc authorities - Match index Test plan: 1. apply patches 2. switch SearchEngine syspref to ElasticSearch 3. load new mapping (admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1) 4. load some unimarc authorities like the sample attached to bug 17373 5. reindex authorities (./misc/search_tools/rebuild_elastic_search.pl -d -a -v) 6. search entire notice for shalev or שלו 7. you should find stuff Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! Oups in second patch : marc_field: 235378abeijkmratsuwxyz Is this correct ? a is there twice. It should be alphabetical order no ? (In reply to Fridolin SOMERS from comment #17) > Oups in second patch : > marc_field: 235378abeijkmratsuwxyz > Is this correct ? a is there twice. > It should be alphabetical order no ? Yes, please provide a follow-up patch here. I pushed a follow-up on the bug 20390. I thing it will be easier to follow the changes and managing 2 bz for the same topic at the same time seems not relevant to me (but I do maybe a wrong choice?). Pushed to 17.11.x for 17.11.08 Not pushed to 17.05.x, resolved |