Summary: | Categories do not display in patron editing form if they have only one category assigned | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Patrons | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P1 - high | CC: | brendan, gmcharlt, jonathan.druart, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15407 | ||
Bug Blocks: | |||
Attachments: |
Bug 17384 - Categories do not display in patron editing form if they have only one category assigned
Bug 17384 - Categories do not display in patron editing form if they have only one category assigned Bug 17384 - Categories do not display in patron editing form if they have only one category assigned |
Description
Marc Véron
2016-09-30 15:07:04 UTC
New way to reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. Created attachment 55962 [details] [review] Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt Created attachment 55966 [details] [review] Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 55973 [details] [review] Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Caused by: commit cae4b980607be083e5e0fb163c4949c73d6347db Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType Really weird line, I guess it's a leftover debug line I put to understand this part of code. Thanks for fixing it! Pushed to Master - Should be in the November Release 16.11 - Thanks! |