Summary: | opac/svc/overdrive_proxy is not plack safe | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | brendan, f.demians, jonathan.druart, julian.maurice, nick, srdjan, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 7172 | ||
Attachments: |
Bug 17392: Make svc/overdrive_proxy plack safe
Bug 17392 - opac/svc/overdrive_proxy is not plack safe Bug 17392 - opac/svc/overdrive_proxy is not plack safe [PASSED QA] Bug 17392 - opac/svc/overdrive_proxy is not plack safe |
Description
Nick Clemens (kidclamp)
2016-10-03 18:54:44 UTC
Created attachment 56016 [details] [review] Bug 17392: Make svc/overdrive_proxy plack safe Just a try, I am not able to test the whole workflow. Please test and adapt if needed. I think that the problem comes from the fact that the CGI->new method is overwritten from the psgi file. (In reply to Jonathan Druart from comment #2) > Just a try, I am not able to test the whole workflow. > Please test and adapt if needed. > I think that the problem comes from the fact that the CGI->new method is > overwritten from the psgi file. And so the -oldstyle_urls pragma is not taken into account. Created attachment 56054 [details] [review] Bug 17392 - opac/svc/overdrive_proxy is not plack safe This patch simply replaces the ';' in the param passed to OverDrive with '&' To test: 1 - Enable overdrive (requires an account) 2 - Perform an opac search 3 - Note the number of overdrive results reported 4 - Click the link to view the actualt overdrive results 5 - Note the result numbers don't match 6 - Apply patch 7 - Repeat 1-4 and note results numbers match and results are relevant 8 - Test a search with a ';' to ensure this patch isn't breaking searches Created attachment 56069 [details] [review] Bug 17392 - opac/svc/overdrive_proxy is not plack safe This patch simply replaces the ';' in the param passed to OverDrive with '&' To test: 1 - Enable overdrive (requires an account) 2 - Perform an opac search 3 - Note the number of overdrive results reported 4 - Click the link to view the actualt overdrive results 5 - Note the result numbers don't match 6 - Apply patch 7 - Repeat 1-4 and note results numbers match and results are relevant 8 - Test a search with a ';' to ensure this patch isn't breaking searches Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 56151 [details] [review] [PASSED QA] Bug 17392 - opac/svc/overdrive_proxy is not plack safe This patch simply replaces the ';' in the param passed to OverDrive with '&' To test: 1 - Enable overdrive (requires an account) 2 - Perform an opac search 3 - Note the number of overdrive results reported 4 - Click the link to view the actual overdrive results 5 - Note the result numbers don't match 6 - Apply patch 7 - Repeat 1-4 and note results numbers match and results are relevant 8 - Test a search with a ';' to ensure this patch isn't breaking searches Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Verified by reading code - couldn't verify using Overdrive. Pushed to Master - Should be in the November 16.11 Release. Thanks! Pushed in 16.05. Will be in 16.05.05. Pushed to 3.22.x, will be in 3.22.12 |