Summary: | Move javascript in doc-head-close.inc into a separate include | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 17418, 17870 | ||
Attachments: |
Bug 17416 - Move javascript in doc-head-close.inc into a separate include
Bug 17416 - Move javascript in doc-head-close.inc into a separate include Bug 17416 - Move javascript in doc-head-close.inc into a separate include Bug 17416: Fix audio alerts Bug 17416 - Move javascript in doc-head-close.inc into a separate include Bug 17416: Fix audio alerts |
Description
Owen Leonard
2016-10-10 09:50:24 UTC
Created attachment 56099 [details] [review] Bug 17416 - Move javascript in doc-head-close.inc into a separate include In order to prepare to move staff client javascript assets into the footer, this patch creates a new include file containing all <script> content. This change should have no visible effect on how pages are generated. To test, apply the patch and view various pages in the staff client (ciruclation, preferences, etc) to confirm that JavaScript is working correctly. Created attachment 56152 [details] [review] Bug 17416 - Move javascript in doc-head-close.inc into a separate include In order to prepare to move staff client javascript assets into the footer, this patch creates a new include file containing all <script> content. This change should have no visible effect on how pages are generated. To test, apply the patch and view various pages in the staff client (ciruclation, preferences, etc) to confirm that JavaScript is working correctly. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Owen, I have created an audio alert (#breadcrumbs using beep.ogg) to test if it works and it does not on the main page. Ok, I have a fix. Created attachment 57719 [details] [review] Bug 17416 - Move javascript in doc-head-close.inc into a separate include In order to prepare to move staff client javascript assets into the footer, this patch creates a new include file containing all <script> content. This change should have no visible effect on how pages are generated. To test, apply the patch and view various pages in the staff client (ciruclation, preferences, etc) to confirm that JavaScript is working correctly. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 57720 [details] [review] Bug 17416: Fix audio alerts Created attachment 57721 [details] [review] Bug 17416 - Move javascript in doc-head-close.inc into a separate include In order to prepare to move staff client javascript assets into the footer, this patch creates a new include file containing all <script> content. This change should have no visible effect on how pages are generated. To test, apply the patch and view various pages in the staff client (ciruclation, preferences, etc) to confirm that JavaScript is working correctly. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 57722 [details] [review] Bug 17416: Fix audio alerts Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patch status is set to "patch doesn't apply" - but both patches appear to have been pushed to master. I am resetting the status to reflect this. These won't get backported to 16.11.x as it is an enhancement. |