Summary: | Correct invalid markup around news on the staff client home page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle, veron |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 17417 - Correct invalid markup around news on the staff client home page
Bug 17417 - Correct invalid markup around news on the staff client home page Bug 17417 [Revised] Correct invalid markup around news on the staff client home page [PASSED QA] Bug 17417 [Revised] Correct invalid markup around news on the staff client home page |
Description
Owen Leonard
2016-10-10 12:15:05 UTC
Created attachment 56094 [details] [review] Bug 17417 - Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from <p> to <div> (because news items might contain <p> and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. Created attachment 56119 [details] [review] Bug 17417 - Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from <p> to <div> (because news items might contain <p> and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. Signed-off-by: Marc <veron@veron.ch> Created attachment 56552 [details] [review] Bug 17417 [Revised] Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from <p> to <div> (because news items might contain <p> and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. Signed-off-by: Marc <veron@veron.ch> Revision for QA removes an extra </div> from elsewhere in the template to make the validator return no errors. Created attachment 56745 [details] [review] [PASSED QA] Bug 17417 [Revised] Correct invalid markup around news on the staff client home page This patch fixes two minor errors in the markup around displaying news on the staff client home page: Adding a missing "class" attribute, and changing the container around news items from <p> to <div> (because news items might contain <p> and nesting them is incorrect). To test, apply the patch and view the staff client home page with news items showing. Validate the page and confirm that there are no errors. Signed-off-by: Marc <veron@veron.ch> Revision for QA removes an extra </div> from elsewhere in the template to make the validator return no errors. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Owen! Pushed in 16.05. Will be in 16.05.06. Pushed to 3.22.x, will be in 3.22.13 |