Summary: | AutoCommit should not be set in tests | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, julian.maurice, kyle, m.de.rooy, veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17426: Do not set AutoCommit in tests
Bug 17426: Do not set AutoCommit in tests Bug 17426: Do not set AutoCommit in tests |
Description
Jonathan Druart
2016-10-11 12:15:20 UTC
Created attachment 56171 [details] [review] Bug 17426: Do not set AutoCommit in tests git grep AutoCommit t | grep 1 highlights that 1 test use AutoCommit set, it should not The other change removes the FIXME should has been fixed. Test plan: prove t/db_dependent/BackgroundJob.t t/db_dependent/Patron/Borrower_Discharge.t should still return green Created attachment 56192 [details] [review] Bug 17426: Do not set AutoCommit in tests git grep AutoCommit t | grep 1 highlights that 1 test use AutoCommit set, it should not The other change removes the FIXME should has been fixed. Test plan: prove t/db_dependent/BackgroundJob.t t/db_dependent/Patron/Borrower_Discharge.t should still return green Signed-off-by: Marc <veron@veron.ch> Created attachment 56692 [details] [review] Bug 17426: Do not set AutoCommit in tests git grep AutoCommit t | grep 1 highlights that 1 test use AutoCommit set, it should not The other change removes the FIXME should has been fixed. Test plan: prove t/db_dependent/BackgroundJob.t t/db_dependent/Patron/Borrower_Discharge.t should still return green Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> +# FIXME Should be a Koha::Object object +is( ref(Koha::Patron::Discharge::request({ borrowernumber => $patron->{borrowernumber} })), 'Koha::Schema::Result::Discharge', 'Discharge request sent' ); Did you open a new bug report for that? (In reply to Marcel de Rooy from comment #4) > +# FIXME Should be a Koha::Object object > +is( ref(Koha::Patron::Discharge::request({ borrowernumber => > $patron->{borrowernumber} })), 'Koha::Schema::Result::Discharge', 'Discharge > request sent' ); > > Did you open a new bug report for that? Nope, it's more a note than a FIXME. The whole Koha::Patron::Discharge would need a rewrite not to use the DBIx::Class rs directly. Pushed to master for 16.11, thanks Jonathan! Pushed in 16.05. Will be in 16.05.05. Pushed in 3.22.x, will be in 3.22.12 |