Description
Bob Ewart
2016-10-18 21:11:00 UTC
I still can find to "Deny from all" doing a git grep on the current codebase. *** Bug 18883 has been marked as a duplicate of this bug. *** Still a problem in 2020. I was just setting up Koha 19.11 from source and etc/koha-httpd.conf is still set up for Apache 2.2. (I may as well take a minute to write a patch for this now.) Created attachment 97294 [details] [review] Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive Note that I'm only fixing the existing access control issue. I haven't added a patch regarding potentially missing Directory directives. Created attachment 99679 [details] [review] Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Old syntax still valid with mod_access_compat, but not for long. Works, no errors. Created attachment 99839 [details] [review] Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is now a hard error Patch change Apache access control from 2.2 to 2.4 directives. Test plan: 0. Apply patch 1. Build Koha from source 2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant Apache directory. 3. Reload Apache 4. Note a lack of syntax errors regarding the "Order" directive Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Old syntax still valid with mod_access_compat, but not for long. Works, no errors. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> And another one (bug) bites the dust... Verified by reading the patch and checking with my notes from strugglng with Apache2 back then. Nice work everyone! Pushed to master for 20.05 Pushed to 19.11.x branch for 19.11.05 backported to 19.05.x for 19.05.10 Backported to 18.11.x for 18.11.16 |