Summary: | Remove koha-*-zebra scripts in favor of koha-zebra | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Command-line Utilities | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | barton, hagud, jonathan.druart, josef.moravec, kyle, martin.renvoize, mirko, mtompset, robin, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20048 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
The new koha-zebra maintenance script replaces the old koha-start-zebra, koha-stop-zebra and koha-restart-zebra scripts. This patch removes them, while keeping backwards compatibility (i.e. you can still run them until you get used to the new syntax).
|
Version(s) released in: | |
Circulation function: | |||
Bug Depends on: | 4880, 17467, 19610, 20234 | ||
Bug Blocks: | 18114 | ||
Attachments: |
Bug 17468: Remove koha-*-zebra scripts and its traces
Bug 17468: Create koha-*-zebra as symlinks to koha-zebra for backwards compatibility Bug 17468: Remove koha-*-zebra scripts and its traces Bug 17468: Create koha-*-zebra as symlinks to koha-zebra for backwards compatibility [Backwards compatible] Bug 17468: Remove koha-*-zebra scripts and its traces Bug 17468: Remove koha-*-zebra scripts and its traces Bug 17468: Remove koha-*-zebra scripts and its traces |
Description
Tomás Cohen Arazi (tcohen)
2016-10-19 13:29:03 UTC
Created attachment 56672 [details] [review] Bug 17468: Remove koha-*-zebra scripts and its traces Created attachment 56673 [details] [review] Bug 17468: Create koha-*-zebra as symlinks to koha-zebra for backwards compatibility Created attachment 56702 [details] [review] Bug 17468: Remove koha-*-zebra scripts and its traces Created attachment 56703 [details] [review] Bug 17468: Create koha-*-zebra as symlinks to koha-zebra for backwards compatibility I rebased this patches on top of bug 4880, as the latter is more important for the stable branches. Comment on attachment 56702 [details] [review] Bug 17468: Remove koha-*-zebra scripts and its traces Review of attachment 56702 [details] [review]: ----------------------------------------------------------------- Where is koha-zebra? ::: debian/koha-common.bash-completion @@ -132,5 @@ > > -# koha-*-zebra autocomplete with enabled instances > -complete -F _koha_enabled_instances koha-start-zebra > -complete -F _koha_enabled_instances koha-restart-zebra > -complete -F _koha_enabled_instances koha-stop-zebra Shouldn't this be: complete -F _koha_enabled_instances koha-zebra ? ::: debian/koha-common.install @@ -30,5 @@ > debian/scripts/koha-run-backups usr/sbin > debian/scripts/koha-shell usr/sbin > debian/scripts/koha-sitemap usr/sbin > -debian/scripts/koha-start-zebra usr/sbin > -debian/scripts/koha-stop-zebra usr/sbin Shouldn't there be a: debian/scripts/koha-zebra usr/sbin ? (In reply to M. Tompsett from comment #6) > Comment on attachment 56702 [details] [review] [review] > Bug 17468: Remove koha-*-zebra scripts and its traces > > Review of attachment 56702 [details] [review] [review]: > ----------------------------------------------------------------- > > Where is koha-zebra? > > ::: debian/koha-common.bash-completion > @@ -132,5 @@ > > > > -# koha-*-zebra autocomplete with enabled instances > > -complete -F _koha_enabled_instances koha-start-zebra > > -complete -F _koha_enabled_instances koha-restart-zebra > > -complete -F _koha_enabled_instances koha-stop-zebra > > Shouldn't this be: > complete -F _koha_enabled_instances koha-zebra > ? > > ::: debian/koha-common.install > @@ -30,5 @@ > > debian/scripts/koha-run-backups usr/sbin > > debian/scripts/koha-shell usr/sbin > > debian/scripts/koha-sitemap usr/sbin > > -debian/scripts/koha-start-zebra usr/sbin > > -debian/scripts/koha-stop-zebra usr/sbin > > Shouldn't there be a: > debian/scripts/koha-zebra usr/sbin > ? Look at the dependencies for this bug. Hi Tomas, can you pleas add a test plan and instructions on how to test with kohadevbox? I seem to remember I need to copy the files somewhere. (In reply to Katrin Fischer from comment #8) > Hi Tomas, can you pleas add a test plan and instructions on how to test with > kohadevbox? I seem to remember I need to copy the files somewhere. You need to have the dependency bug, run reset _all, delete the koha-*-zebra (excluding rebuild) scripts, and create links to koha-zebra, named as the deleted commands. Then test the 'legacy' commands still work. The dep bug, implementing koha-zebra is the juicy one. He (In reply to Tomás Cohen Arazi from comment #9) > (In reply to Katrin Fischer from comment #8) > > Hi Tomas, can you pleas add a test plan and instructions on how to test with > > kohadevbox? I seem to remember I need to copy the files somewhere. > > You need to have the dependency bug, run reset _all, delete the koha-*-zebra > (excluding rebuild) scripts, and create links to koha-zebra, named as the > deleted commands. That's the problem - I don't remember what to copy from where to where. Can you add a bit more detailed instructions or an example? I can try to find a place on the wiki for it. > Then test the 'legacy' commands still work. The dep bug, implementing > koha-zebra is the juicy one. That one is in now :) Bug 20048 was added as a see also, because the --status flag was uncheckable while testing this. This, however, does seem to work just fine as a replacement for the koha-stop-zebra, koha-start-zebra, and koha-restart-zebra scripts. Created attachment 71885 [details] [review] [Backwards compatible] Bug 17468: Remove koha-*-zebra scripts and its traces This patch removes traces from the (deprecated) koha-*-zebra scripts. To test: - Apply the patch - Verify no traces of koha-*-zebra remain on the codebase (besides Release Notes and the koha-zebra script): $ cd kohaclone $ git grep koha-start-zebra $ git grep koha-stop-zebra $ git grep koha-restart-zebra => SUCCESS: No traces! - Create the following symlinks: $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-start-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-stop-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-restart-zebra - Try the koha-*-zebra commands: $ sudo koha-stop-zebra kohadev $ sudo koha-start-zebra kohadev $ sudo koha-restart-zebra kohadev => SUCCESS: They all work as expected! - Sign off :-D! Sponsored-by: Orex Digital Created attachment 71886 [details] [review] Bug 17468: Remove koha-*-zebra scripts and its traces This patch removes traces from the (deprecated) koha-*-zebra scripts. To test: - Apply the patch - Verify no traces of koha-*-zebra remain on the codebase (besides Release Notes): $ cd kohaclone $ git grep koha-start-zebra $ git grep koha-stop-zebra $ git grep koha-restart-zebra => SUCCESS: No traces! - Sign off :-D! Sponsored-by: Orex Digital I consolidated this work on a single patch. But added two optional in¡mplementations: - [Backwards compatible]: This one removes all the koha-*-zebra things, and makes use of the backward-compatibility baked inside koha-zebra so people can still use the old scripts, but will receive a gentle warning suggesting the use of koha-zebra instead. - The second option removes everything, including the koha-zebra backwards compatibility option. I'm more in favour of the backwards compatible version. I wished it was included in 17.11 so we had at least one release for people to see the warnings and get used to the change. koha-*-sip will have the same future. My only problem with backwards compatibility is that I would like Mirko's opinion on the way I handled it. We can move forward anyway (it works, follows Debian's instructions, etc). Katrin: I amended the test steps so it is easy to try the backwards compatibility. (In reply to Tomás Cohen Arazi from comment #14) > My only problem with backwards compatibility is that I would like Mirko's > opinion on the way I handled it. We can move forward anyway (it works, > follows Debian's instructions, etc). +1 for backwards compatibility. I have not tested the patch yet, but the implementation makes sense to me. Created attachment 72492 [details] [review] Bug 17468: Remove koha-*-zebra scripts and its traces This patch removes traces from the (deprecated) koha-*-zebra scripts. To test: - Apply the patch - Verify no traces of koha-*-zebra remain on the codebase (besides Release Notes and the koha-zebra script): $ cd kohaclone $ git grep koha-start-zebra $ git grep koha-stop-zebra $ git grep koha-restart-zebra => SUCCESS: No traces! - Create the following symlinks: $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-start-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-stop-zebra $ sudo ln -s /usr/sbin/koha-zebra /usr/sbin/koha-restart-zebra - Try the koha-*-zebra commands: $ sudo koha-stop-zebra kohadev $ sudo koha-start-zebra kohadev $ sudo koha-restart-zebra kohadev => SUCCESS: They all work as expected! - Sign off :-D! Sponsored-by: Orex Digital Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! |