Summary: | Borrower Previously Checked Out: Display title | ||
---|---|---|---|
Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
Component: | Circulation | Assignee: | Alex Sassmannshausen <alex> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | alex, black23, gmcharlt, jonathan.druart, josef.moravec, kyle.m.hall, kyle, mail, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 6906 | ||
Bug Blocks: | |||
Attachments: |
Bug 17472: Add title, barcode to warning message.
Bug 17472: Add title, not barcode, to warning. [SIGNED-OFF] Bug 17472: Add title to warning message for PREVCHECKOUT Bug 17472: Borrower Previously Checked Out: Display title Bug 17472: Borrower Previously Checked Out: Display title |
Description
Josef Moravec
2016-10-20 08:03:56 UTC
Created attachment 56717 [details] [review] Bug 17472: Add title, barcode to warning message. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add Title and Barcode to PREVISSUE message. Thinking about it, my patch adds title and barcode. It may be preferable to add only the title, given that the same bib may have been issued in the past, but not necessarily the same item. WDYT? Alex Created attachment 56718 [details] [review] Bug 17472: Add title, not barcode, to warning. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add item title, reword message, for PREVISSUE. I've decided to remove the barcode, as the request itself only mentions title too. Alex Created attachment 56721 [details] [review] [SIGNED-OFF] Bug 17472: Add title to warning message for PREVCHECKOUT * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add Title to PREVISSUE message. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Thank Alex, I agree, the important thing is the title, not barcode. As your second patch was written on top of the previous one, I squashed them. Signing off This is not a good mark-up for translation: + <li>Title <i>[% getTitleMessageIteminfo %]</i> has previously been checked out to this patron. Check out anyway?</li> The use of <i> splits the sentence into multiple parts. Please reformat in a way that will be easier to translate. Created attachment 57247 [details] [review] Bug 17472: Borrower Previously Checked Out: Display title Test plan: 0) apply the patch 1) turn on checking previously checkouts - syspref CheckPrevCheckout 2) checkout an item to borrower 3) check the item in and check it out again, you should see the dialog, with information that the current item was previously checked out to this patron. With this patch, the information includes title and author of the item Patch tested with a sandbox, by Nick Clemens <nick@bywatersolutions.com> I am lost with the different patches. Could someone tell me which one is the good one? Authorship has changed between the first submission and the last patch. Hi Jonathan, This is probably clear by now (I saw you obsoleted a patch). The right patch is Josef's. Best wishes, Alex Created attachment 58161 [details] [review] Bug 17472: Borrower Previously Checked Out: Display title Test plan: 0) apply the patch 1) turn on checking previously checkouts - syspref CheckPrevCheckout 2) checkout an item to borrower 3) check the item in and check it out again, you should see the dialog, with information that the current item was previously checked out to this patron. With this patch, the information includes title and author of the item Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Josef! This won't get backported to 16.11.x as it is an enhancement. |