Bug 17476

Summary: Failed test 'Create DateTime with dt_from_string() for 2100-01-01 with TZ in less than 2s'
Product: Koha Reporter: Mirko Tietgen <mirko>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart+koha>
Status: CLOSED FIXED QA Contact: Galen Charlton <gmcharlt>
Severity: normal    
Priority: P5 - low CC: kyle, mtj
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 17476: Add a way to bypass dt_from_string processing time for slow servers
Bug 17476: Add a way to bypass dt_from_string processing time for slow servers
[PASSED QA] Bug 17476: Add a way to bypass dt_from_string processing time for slow servers

Description Mirko Tietgen 2016-10-20 12:18:06 UTC
A test for DateUtils.t fails on slow servers. There should be a way to skip it.

#   Failed test 'Create DateTime with dt_from_string() for 2100-01-01 with TZ in less than 2s'
#   at t/DateUtils.t line 82.
#     '2.51043486595154'
#         <
#     '2'
# Looks like you failed 1 test of 60.
t/DateUtils.t .......................
Comment 1 Jonathan Druart 2016-10-21 07:20:18 UTC
Created attachment 56716 [details] [review]
Bug 17476: Add a way to bypass dt_from_string processing time for slow servers

    Bug 17476: Add a way to bypass dt_from_string processing time for slow servers
    
    We already change this value from 1 to 2 but apparently it's not enough
    So let's switch it back to on and add a flag (env var SLOW_SERVER) and skip these tests
    if set
    
    Test plan:
      prove t/DateUtils.t
    and
      SLOW_SERVER=1 prove t/DateUtils.t
    
    should return green
Comment 2 Mirko Tietgen 2016-10-21 10:08:00 UTC
Created attachment 56719 [details] [review]
Bug 17476: Add a way to bypass dt_from_string processing time for slow servers

We already change this value from 1 to 2 but apparently it's not enough
So let's switch it back to on and add a flag (env var SLOW_SERVER) and skip these tests
if set

Test plan:
  prove t/DateUtils.t
and
  SLOW_SERVER=1 prove t/DateUtils.t

should return green

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Comment 3 Katrin Fischer 2016-11-06 10:50:13 UTC
Created attachment 57232 [details] [review]
[PASSED QA] Bug 17476: Add a way to bypass dt_from_string processing time for slow servers

We already change this value from 1 to 2 but apparently it's not enough
So let's switch it back to on and add a flag (env var SLOW_SERVER) and skip these tests
if set

Test plan:
  prove t/DateUtils.t
and
  SLOW_SERVER=1 prove t/DateUtils.t

should return green

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
Comment 4 Kyle M Hall 2016-11-07 16:37:07 UTC
Pushed to master for 16.11, thanks Jonathan!
Comment 5 Mason James 2016-12-14 10:07:26 UTC
Pushed to 16.05.x, for 16.05.06 release