|
Description
Radek Šiman (R-Bit Technology, s.r.o.)
2016-10-23 19:38:12 UTC
Created attachment 56735 [details] [review] Links to "select/clear all" moved below the header tag Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header Radek, we probably can omit the whole style attribute in span, as the span is no more in h2 tag, the style attribute isn't necessary. What do you think? I've tried to remove it, but it looks better with the left padding. On the other hand, display:inline is useless, you're right. So? Should we remove the outer span at all, or just display:inline? (In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #3) > I've tried to remove it, but it looks better with the left padding. On the > other hand, display:inline is useless, you're right. So? Should we remove > the outer span at all, or just display:inline? What looks better is on everyone opinion, so I'm OK with removing only display:inline thanks Created attachment 56736 [details] [review] Styling moved from style attribute into staff-global.css Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header 4) [Optionally] Set some style in IntranetUserCSS for class z3950checks Created attachment 56737 [details] [review] [SIGNED-OFF] Bug 17487: Links to "select/clear all" moved below the header tag Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header https://bugs.koha-community.org/show_bug.cgi?id=17487 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 56738 [details] [review] [SIGNED-OFF] Bug 17487: Styling moved from style attribute into staff-global.css Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header 4) [Optionally] Set some style in IntranetUserCSS for class z3950checks https://bugs.koha-community.org/show_bug.cgi?id=17487 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 56834 [details] [review] Bug 17487: Links to "select/clear all" moved below the header tag Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header https://bugs.koha-community.org/show_bug.cgi?id=17487 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 56835 [details] [review] Bug 17487: Styling moved from style attribute into staff-global.css Test plan: 1) Apply patch 2) Display Z39.50 search dialogs: - cataloguing / new from Z39.50 - authorities / new from Z39.50 - acquisition / new from an external source 3) Select all / Clear all should be placed below "Search targets" header 4) [Optionally] Set some style in IntranetUserCSS for class z3950checks https://bugs.koha-community.org/show_bug.cgi?id=17487 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This applies to 16.05, but also to 16.11 or master. Version is set to 16.05. What should be done? Kyle: should be for master too, as confirmed by Jonathan. Pushed to master for 17.05, thanks Radek! Contains strings - holding this back for possible inclusion in 16.11.3. This patch has been pushed to 16.11.x and will be in 16.11.04. Pushed to 3.22.x for 3.22.17 Pushed to 16.05.x, for 16.05.10 release |