Summary: | reports/issues_stats.pl is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Reports | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | kyle, mtj, veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15407, 17425 | ||
Bug Blocks: | 7679 | ||
Attachments: |
Bug 17495: Fix 'method selected not covered by test' in reports/issues_stats.pl
Bug 17495: Fix 'method selected not covered by test' in reports/issues_stats.pl [PASSED QA] Bug 17495: Fix 'method selected not covered by test' in reports/issues_stats.pl |
Description
Jonathan Druart
2016-10-25 07:21:13 UTC
Created attachment 56828 [details] [review] Bug 17495: Fix 'method selected not covered by test' in reports/issues_stats.pl If you access reports/issues_stats.pl, you will get Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121 http://localhost:8081/cgi-bin/koha/reports/reports-home.pl Bug 15407 sent objects to the template and the selected method is not defined. The bug had been highlighted by bug 17425 which dies instead of hides the error. Not that the "selected" code was not needed, the different elements of the page never select a specific value. Test plan: Apply this patch and confirm that the error is no longuer displayed. Created attachment 56866 [details] [review] Bug 17495: Fix 'method selected not covered by test' in reports/issues_stats.pl If you access reports/issues_stats.pl, you will get Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121 http://localhost:8081/cgi-bin/koha/reports/reports-home.pl Bug 15407 sent objects to the template and the selected method is not defined. The bug had been highlighted by bug 17425 which dies instead of hides the error. Not that the "selected" code was not needed, the different elements of the page never select a specific value. Test plan: Apply this patch and confirm that the error is no longuer displayed. Reproduced. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 56876 [details] [review] [PASSED QA] Bug 17495: Fix 'method selected not covered by test' in reports/issues_stats.pl If you access reports/issues_stats.pl, you will get Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121 http://localhost:8081/cgi-bin/koha/reports/reports-home.pl Bug 15407 sent objects to the template and the selected method is not defined. The bug had been highlighted by bug 17425 which dies instead of hides the error. Not that the "selected" code was not needed, the different elements of the page never select a specific value. Test plan: Apply this patch and confirm that the error is no longuer displayed. Reproduced. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Jonathan! Pushed to 16.05.x, for 16.05.06 release |