Summary: | Regression: Search for reports by keywords | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Reports | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle, mtj |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 14435 | ||
Bug Blocks: | 22357 | ||
Attachments: |
Bug 17535: Fix search for reports by keywords
[SIGNED-OFF] Bug 17535: Fix search for reports by keywords [PASSED QA] Bug 17535: Fix search for reports by keywords |
Description
Jonathan Druart
2016-11-02 09:36:45 UTC
Created attachment 57069 [details] [review] Bug 17535: Fix search for reports by keywords The commit cf9031711282f4be23e4a639797d0fd178940e1f Bug 14435: Add the ability to store result's report introduced a regression when searching for reports by keywords. It also breaks tests in t/db_dependent/Reports/Guided.t It's caused by the missing join on saved_reports. The error says DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' Test plan: Confirm that the tests are fixed and that you are able to search for reports using the "keyword" input Created attachment 57106 [details] [review] [SIGNED-OFF] Bug 17535: Fix search for reports by keywords The commit cf9031711282f4be23e4a639797d0fd178940e1f Bug 14435: Add the ability to store result's report introduced a regression when searching for reports by keywords. It also breaks tests in t/db_dependent/Reports/Guided.t It's caused by the missing join on saved_reports. The error says DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' Test plan: Confirm that the tests are fixed and that you are able to search for reports using the "keyword" input Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57229 [details] [review] [PASSED QA] Bug 17535: Fix search for reports by keywords The commit cf9031711282f4be23e4a639797d0fd178940e1f Bug 14435: Add the ability to store result's report introduced a regression when searching for reports by keywords. It also breaks tests in t/db_dependent/Reports/Guided.t It's caused by the missing join on saved_reports. The error says DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' Test plan: Confirm that the tests are fixed and that you are able to search for reports using the "keyword" input Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Jonathan! Blocked by enhancement, skipping for 16.05.x |