Summary: | Remove Duplication of receipting code in EDI | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Acquisitions | Assignee: | Martin Renvoize <martin.renvoize> |
Status: | ASSIGNED --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 7736 | ||
Bug Blocks: | |||
Attachments: | Proposed patch |
Description
Colin Campbell
2016-11-02 10:22:22 UTC
Created attachment 57071 [details] [review] Proposed patch This patch removes the code which duplicated functionality from C4::Acquisitions and instead calls ModReceiveOrder. Removes potential divergencies from the two paths. Koha::EDI now only required to load data provided by the GIR segment in the invoice. This removes some anomalies which caused partial receipts to sometimes skip adding a barcode to some items (if supplier applies barcodes) Looking at a small change to this patch to eliminate an unnecssary warning It looks like this patch was never finished. Should we reset to NEW/unassigned? I'll take a look, see if I can work out what was being done here. |