Summary: | xt/author/valid-templates.t is broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle, mtj |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 15758, 15803 | ||
Bug Blocks: | |||
Attachments: |
Bug 17537: Fix valid-templates.t for some include files
Bug 17537: Fix valid-templates.t for some include files Bug 17537: Fix valid-templates.t for some include files |
Description
Jonathan Druart
2016-11-02 10:50:42 UTC
Created attachment 57076 [details] [review] Bug 17537: Fix valid-templates.t for some include files 3 include files do not pass the template validation tests: - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc This is because they process a block which has not been declared before. As they are include files, they cannot stand on their own. We could have added them to the exclude file list of xt/author/valid-templates.t but I think it's better to keep them into the validation loop. Test plan: prove xt/author/valid-templates.t should return green And the library dropdown list should be correctly populated on the pages these files are included (opac-topissues for instance) Created attachment 57103 [details] [review] Bug 17537: Fix valid-templates.t for some include files 3 include files do not pass the template validation tests: - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc This is because they process a block which has not been declared before. As they are include files, they cannot stand on their own. We could have added them to the exclude file list of xt/author/valid-templates.t but I think it's better to keep them into the validation loop. Test plan: prove xt/author/valid-templates.t should return green And the library dropdown list should be correctly populated on the pages these files are included (opac-topissues for instance) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 57132 [details] [review] Bug 17537: Fix valid-templates.t for some include files 3 include files do not pass the template validation tests: - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc This is because they process a block which has not been declared before. As they are include files, they cannot stand on their own. We could have added them to the exclude file list of xt/author/valid-templates.t but I think it's better to keep them into the validation loop. Test plan: prove xt/author/valid-templates.t should return green And the library dropdown list should be correctly populated on the pages these files are included (opac-topissues for instance) Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 16.11, thanks Jonathan! blocked by enhancement, passing for 16.05.x series Blocked by enhancement, skipping for 16.05.x |