Summary: | (MARC21) Chronological term link subfield 648$9 not indexed | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | MARC Bibliographic data support | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | hagud, jonathan.druart, julian.maurice, kyle, magnus, mtj |
Version: | 16.11 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17547: (MARC21|NORMARC) have Chronological term field $9 indexed
Bug 17547: (MARC21|NORMARC) have Chronological term field $9 indexed |
Description
Tomás Cohen Arazi (tcohen)
2016-11-03 15:18:40 UTC
Created attachment 57946 [details] [review] Bug 17547: (MARC21|NORMARC) have Chronological term field $9 indexed This patch makes Zebra index the 648$9 link for chronological terms on bibliographic records. This way an authority search on chronological terms will show the right number in 'Used in X records' message. To test: - Have a record with a 648 field, linked to an authority record (i.e. with an authid on 648$9). - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => FAIL: the term is linked to our record, but koha shows '0' count. - Apply the patch - Run: $ cd kohaclone $ xsltproc etc/zebra/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ git diff => SUCCESS: Notice the shipped etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl is up-to-date - Run: $ sudo cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ sudo koha-restart-zebra kohadev $ sudo koha-rebuild-zebra -f -b -v kohadev - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => SUCCESS: the term is linked to our record, usage count is 1 - Sign off :-D I assume NORMARC is similar on this regard. Feel free to fail it if the NORMARC part of the patch is wrong. Sponsored-by: Universidad Nacional de Cordoba We have applied the patch and it works.. just a litle note, there is a mispelling in the test plan Instead of sudo xsltproc etc/zebra/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl the right one is sudo xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl (In reply to Tomás Cohen Arazi from comment #1) > I assume NORMARC is similar on this regard. Feel free to fail it if the > NORMARC part of the > patch is wrong. Magnus, could you confirm? (In reply to Jonathan Druart from comment #3) > (In reply to Tomás Cohen Arazi from comment #1) > > I assume NORMARC is similar on this regard. Feel free to fail it if the > > NORMARC part of the > > patch is wrong. > > Magnus, could you confirm? Akshuly, there is no 648 in NORMARC, and no other field is used for "Chronological term" either, as far as I can tell. Does that mean we need to remove NORMARC changes, to keep them or that does not matter? :) (In reply to Jonathan Druart from comment #5) > Does that mean we need to remove NORMARC changes, to keep them or that does > not matter? :) My gut feeling says to just keep them. It should not hurt anyone. Created attachment 58168 [details] [review] Bug 17547: (MARC21|NORMARC) have Chronological term field $9 indexed This patch makes Zebra index the 648$9 link for chronological terms on bibliographic records. This way an authority search on chronological terms will show the right number in 'Used in X records' message. To test: - Have a record with a 648 field, linked to an authority record (i.e. with an authid on 648$9). - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => FAIL: the term is linked to our record, but koha shows '0' count. - Apply the patch - Run: $ cd kohaclone $ xsltproc etc/zebra/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ git diff => SUCCESS: Notice the shipped etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl is up-to-date - Run: $ sudo cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl $ sudo koha-restart-zebra kohadev $ sudo koha-rebuild-zebra -f -b -v kohadev - Search for the record, notice it is indexed. - Perform an authority search for the chronological term => SUCCESS: the term is linked to our record, usage count is 1 - Sign off :-D I assume NORMARC is similar on this regard. Feel free to fail it if the NORMARC part of the patch is wrong. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Tomas! This patch has been pushed to 16.11.x, will be in 16.11.01. Pushed to 3.22.x for 3.22.14 Pushed to 16.05.x, for 16.05.06 release |