Summary: | Step 1 of memberentry explodes | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | kyle, mtj |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15407 | ||
Bug Blocks: | 17521 | ||
Attachments: |
Bug 17548: Fix step 1 of memberentry
[SIGNED-OFF] Bug 17548: Fix step 1 of memberentry [PASSED QA] Bug 17548: Fix step 1 of memberentry |
Description
Jonathan Druart
2016-11-04 09:18:36 UTC
Created attachment 57158 [details] [review] Bug 17548: Fix step 1 of memberentry This bug has been highlighted by bug 15407. The date limit check on the category code did not work on step 1. But after bug 15407 the script crashes with Can't call method "dateofbirthrequired" on an undefined value at /home/vagrant/kohaclone/members/memberentry.pl line 311. Test plan: - Edit "step 1" information of a patron (first 'Edit' on a patron detail page). - Save => Without this patch it BOOMs => With this patch, the info should be correctly saved Created attachment 57167 [details] [review] [SIGNED-OFF] Bug 17548: Fix step 1 of memberentry This bug has been highlighted by bug 15407. The date limit check on the category code did not work on step 1. But after bug 15407 the script crashes with Can't call method "dateofbirthrequired" on an undefined value at /home/vagrant/kohaclone/members/memberentry.pl line 311. Test plan: - Edit "step 1" information of a patron (first 'Edit' on a patron detail page). - Save => Without this patch it BOOMs => With this patch, the info should be correctly saved Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57227 [details] [review] [PASSED QA] Bug 17548: Fix step 1 of memberentry This bug has been highlighted by bug 15407. The date limit check on the category code did not work on step 1. But after bug 15407 the script crashes with Can't call method "dateofbirthrequired" on an undefined value at /home/vagrant/kohaclone/members/memberentry.pl line 311. Test plan: - Edit "step 1" information of a patron (first 'Edit' on a patron detail page). - Save => Without this patch it BOOMs => With this patch, the info should be correctly saved Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Jonathan! bug is confirmed to not exist in 16.05, passing for 16.05 |