Description
Jonathan Druart
2016-11-04 14:07:51 UTC
Created attachment 57200 [details] [review] Bug 17552: Revert "Bug 17091: Remove explicit declaration of Koha::Objects->reset" This reverts commit c253af2e519570c4024891dc4d1e81743a2c5fc2. Created attachment 57201 [details] [review] Bug 17552: Continue revert and add tests to highlight the problem Is there any other test plan than prove t/db_dependent/Koha/Objects.t ? (In reply to Josef Moravec from comment #3) > Is there any other test plan than > prove t/db_dependent/Koha/Objects.t > ? Nope, this method is not called from our codebase (only from tests). Created attachment 57209 [details] [review] [SIGNED-OFF] Bug 17552: Revert "Bug 17091: Remove explicit declaration of Koha::Objects->reset" This reverts commit c253af2e519570c4024891dc4d1e81743a2c5fc2. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57210 [details] [review] [SIGNED-OFF] Bug 17552: Continue revert and add tests to highlight the problem Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57230 [details] [review] [PASSED QA] Bug 17552: Revert "Bug 17091: Remove explicit declaration of Koha::Objects->reset" This reverts commit c253af2e519570c4024891dc4d1e81743a2c5fc2. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 57231 [details] [review] [PASSED QA] Bug 17552: Continue revert and add tests to highlight the problem Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Jonathan! Blocked by enhancement, skipping for 16.05.x |