Summary: | Remove issue.t warnings | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle, m.de.rooy, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 14598 | ||
Bug Blocks: | |||
Attachments: |
Bug 17572: Remove itemtype-related warnings from issue.t
Bug 17572: (followup) Remove test's hardcoded values [SIGNED-OFF] Bug 17572: Remove itemtype-related warnings from issue.t [SIGNED-OFF] Bug 17572: (followup) Remove test's hardcoded values Bug 17572: Remove itemtype-related warnings from issue.t Bug 17572: (followup) Remove test's hardcoded values Bug 17572: [QA Follow-up] Cosmetic changes |
Description
Tomás Cohen Arazi (tcohen)
2016-11-07 17:35:50 UTC
Created attachment 57272 [details] [review] Bug 17572: Remove itemtype-related warnings from issue.t This patch makes t/db_dependent/Circulation/issue.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/issue.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Created attachment 57273 [details] [review] Bug 17572: (followup) Remove test's hardcoded values This patch makes the tests use t::lib::TestBuilder instead of hardcoding values. Test plan: - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: All tests return green with and without the patch - Sign off :-D Sponsored-by: ByWater Solutions Created attachment 57275 [details] [review] [SIGNED-OFF] Bug 17572: Remove itemtype-related warnings from issue.t This patch makes t/db_dependent/Circulation/issue.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/issue.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57276 [details] [review] [SIGNED-OFF] Bug 17572: (followup) Remove test's hardcoded values This patch makes the tests use t::lib::TestBuilder instead of hardcoding values. Test plan: - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: All tests return green with and without the patch - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57449 [details] [review] Bug 17572: Remove itemtype-related warnings from issue.t This patch makes t/db_dependent/Circulation/issue.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/issue.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 57450 [details] [review] Bug 17572: (followup) Remove test's hardcoded values This patch makes the tests use t::lib::TestBuilder instead of hardcoding values. Test plan: - Run: $ prove t/db_dependent/Circulation/issue.t => SUCCESS: All tests return green with and without the patch - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 57451 [details] [review] Bug 17572: [QA Follow-up] Cosmetic changes Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 16.11, thanks Tomas! Pushed to 16.05.x, for 16.05.06 release |