Summary: | Remove itemtype-related maxsuspensiondays.t warnings | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | kyle, m.de.rooy, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings
[SIGNED-OFF] Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings |
Description
Tomás Cohen Arazi (tcohen)
2016-11-08 19:27:57 UTC
Created attachment 57349 [details] [review] Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings This patch makes t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Created attachment 57368 [details] [review] [SIGNED-OFF] Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings This patch makes t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57444 [details] [review] Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings This patch makes t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 16.11, thanks Tomas! Pushed to 16.05.x, for 16.05.06 release |