| Summary: | Tests should not call set_preference | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | kyle, mtj, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17599 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 17633: Do not call set_preference from tests
[SIGNED-OFF] Bug 17633: Do not call set_preference from tests Bug 17633: Do not call set_preference from tests Bug 17633: (QA followup) Remove unneeded warnings Bug 17633: (QA followup) remove debugging leftover |
||
|
Description
Jonathan Druart
2016-11-15 15:46:00 UTC
Created attachment 57507 [details] [review] Bug 17633: Do not call set_preference from tests If memcached is running, the pref's value will be set in cache, what we do not want. t/db_dependent/Context.t and t/db_dependent/sysprefs.t are exceptions for obvious reasons. Test plan: Make sure all these tests still pass Generated with perl -p -i -e "s/C4::Context->set_preference\((.*),(.*)\);/t::lib::Mocks::mock_preference(\1,\2);/" t/**/*.t Created attachment 57508 [details] [review] [SIGNED-OFF] Bug 17633: Do not call set_preference from tests If memcached is running, the pref's value will be set in cache, what we do not want. t/db_dependent/Context.t and t/db_dependent/sysprefs.t are exceptions for obvious reasons. Test plan: Make sure all these tests still pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57509 [details] [review] Bug 17633: Do not call set_preference from tests If memcached is running, the pref's value will be set in cache, what we do not want. t/db_dependent/Context.t and t/db_dependent/sysprefs.t are exceptions for obvious reasons. Test plan: Make sure all these tests still pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 57510 [details] [review] Bug 17633: (QA followup) Remove unneeded warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 16.11, thanks Jonathan, Tomas! Created attachment 57560 [details] [review] Bug 17633: (QA followup) remove debugging leftover Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Followup pushed to master for 16.11, thanks Tomas! Pushed to 16.05.x, for 16.05.06 release |