| Summary: | Unit test t/db_dependent/ArticleRequests.t is failing | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, mtj, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 17634 - Unit test t/db_dependent/ArticleRequests.t is failing
Bug 17634: Unit test t/db_dependent/ArticleRequests.t is failing Revert "Bug 17634: Unit test t/db_dependent/ArticleRequests.t is failing" Bug 17634: Fix circ dependency with require instead of use Revert "Bug 17634: Unit test t/db_dependent/ArticleRequests.t is failing" Bug 17634: Fix circ dependency with require instead of use |
||
|
Description
Kyle M Hall (khall)
2016-11-15 17:35:56 UTC
Created attachment 57511 [details] [review] Bug 17634 - Unit test t/db_dependent/ArticleRequests.t is failing Test Plan: 1) prove t/db_dependent/ArticleRequests.t 2) Apply this patch 3) prove t/db_dependent/ArticleRequests.t Created attachment 57512 [details] [review] Bug 17634: Unit test t/db_dependent/ArticleRequests.t is failing Test Plan: 1) prove t/db_dependent/ArticleRequests.t 2) Apply this patch 3) prove t/db_dependent/ArticleRequests.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 16.11! This is wrong! It breaks all the tests we have fixed yesterday Created attachment 57520 [details] [review] Revert "Bug 17634: Unit test t/db_dependent/ArticleRequests.t is failing" This reverts commit 75f75101585d795ab6b0e4e40f585b21e0f841cb. Created attachment 57521 [details] [review] Bug 17634: Fix circ dependency with require instead of use This is definitely wrong but we won't have time to fix it correctly before the release. Created attachment 57534 [details] [review] Revert "Bug 17634: Unit test t/db_dependent/ArticleRequests.t is failing" This reverts commit 75f75101585d795ab6b0e4e40f585b21e0f841cb. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 57535 [details] [review] Bug 17634: Fix circ dependency with require instead of use This is definitely wrong but we won't have time to fix it correctly before the release. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Followups pushed to master for 16.11, thanks Jonathan! Pushed to 16.05.x, for 16.05.06 release |