| Summary: | Remove itemtype-related GetIssues.t warnings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | hector.hecaxmmx, kyle, martin.renvoize, mtj |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14598 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 17636: Remove itemtype-related GetIssues.t warnings
[SIGNED-OFF]Bug 17636: Remove itemtype-related GetIssues.t warnings [PASSED QA] Bug 17636: Remove itemtype-related GetIssues.t warnings |
||
|
Description
Tomás Cohen Arazi (tcohen)
2016-11-15 20:40:05 UTC
Created attachment 57515 [details] [review] Bug 17636: Remove itemtype-related GetIssues.t warnings This patch makes t/db_dependent/Circulation/GetIssues.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/GetIssues.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/GetIssues.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Created attachment 57554 [details] [review] [SIGNED-OFF]Bug 17636: Remove itemtype-related GetIssues.t warnings This patch makes t/db_dependent/Circulation/GetIssues.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/GetIssues.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/GetIssues.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successfuly Created attachment 57599 [details] [review] [PASSED QA] Bug 17636: Remove itemtype-related GetIssues.t warnings This patch makes t/db_dependent/Circulation/GetIssues.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/GetIssues.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/GetIssues.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All test pass successfuly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed to master for 16.11, thanks Tomas! Pushed to 16.05.x, for 16.05.06 release |