Bug 17644

Summary: t/db_dependent/Exporter/Record.t fails
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low CC: jonathan.druart, mtj
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 17644 - t/db_dependent/Exporter/Record.t fails
[SIGNED-OFF] Bug 17644 - t/db_dependent/Exporter/Record.t fails
Bug 17644 - t/db_dependent/Exporter/Record.t fails

Description Kyle M Hall 2016-11-16 12:40:19 UTC

    
Comment 1 Kyle M Hall 2016-11-16 12:41:47 UTC
Created attachment 57539 [details] [review]
Bug 17644 - t/db_dependent/Exporter/Record.t fails

Test Plan:
1) prove t/db_dependent/Exporter/Record.t fails
2) Apply this patch
3) prove t/db_dependent/Exporter/Record.t succeeds!
Comment 2 Josef Moravec 2016-11-16 14:31:35 UTC
Created attachment 57547 [details] [review]
[SIGNED-OFF] Bug 17644 - t/db_dependent/Exporter/Record.t fails

Test Plan:
1) prove t/db_dependent/Exporter/Record.t fails
2) Apply this patch
3) prove t/db_dependent/Exporter/Record.t succeeds!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Jonathan Druart 2016-11-17 08:03:41 UTC
I was going to submit a patch to fix this test and found yours.

Note that mine looks simpler:

-Koha::Biblioitems->find( $bad_biblionumber )->marcxml("something wrong")->store;
+Koha::Biblioitems->find( $bad_biblioitemnumber )->marcxml("something wrong")->store;
Comment 4 Jonathan Druart 2016-11-17 08:07:18 UTC
Created attachment 57586 [details] [review]
Bug 17644 - t/db_dependent/Exporter/Record.t fails

Test Plan:
1) prove t/db_dependent/Exporter/Record.t fails
2) Apply this patch
3) prove t/db_dependent/Exporter/Record.t succeeds!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Kyle M Hall 2016-11-17 11:05:58 UTC
Pushed to master for 16.11!
Comment 6 Mason James 2016-12-14 11:19:16 UTC
Pushed to 16.05.x, for 16.05.06 release