Summary: | Remove itemtype-related CancelReceipt.t warnings | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Test Suite | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 14598 | ||
Bug Blocks: | |||
Attachments: |
Bug 17647: Remove itemtype-related CancelReceipt.t warnings
Bug 17647: Remove itemtype-related CancelReceipt.t warnings [PASSED QA] Bug 17647: Remove itemtype-related CancelReceipt.t warnings |
Description
Tomás Cohen Arazi
2016-11-16 19:44:14 UTC
Created attachment 57576 [details] [review] Bug 17647: Remove itemtype-related CancelReceipt.t warnings This patch makes t/db_dependent/Acquisition/CancelReceipt.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Acquisition/CancelReceipt.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Acquisition/CancelReceipt.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Created attachment 57591 [details] [review] Bug 17647: Remove itemtype-related CancelReceipt.t warnings This patch makes t/db_dependent/Acquisition/CancelReceipt.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Acquisition/CancelReceipt.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Acquisition/CancelReceipt.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 57613 [details] [review] [PASSED QA] Bug 17647: Remove itemtype-related CancelReceipt.t warnings This patch makes t/db_dependent/Acquisition/CancelReceipt.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Acquisition/CancelReceipt.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Acquisition/CancelReceipt.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Tomas! Pushed to 16.05.x, for 16.05.06 release |