| Summary: | Remove itemtype-related t/db_dependent/Circulation* warnings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | kyle, mtj |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14598 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings
[SIGNED-OFF] Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings [PASSED QA] Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings |
||
|
Description
Tomás Cohen Arazi (tcohen)
2016-11-17 15:28:00 UTC
Created attachment 57605 [details] [review] Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings This patch makes t/db_dependent/Circulation* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 57610 [details] [review] [SIGNED-OFF] Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings This patch makes t/db_dependent/Circulation* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57614 [details] [review] [PASSED QA] Bug 17653: Remove itemtype-related t/db_dependent/Circulation* warnings This patch makes t/db_dependent/Circulation* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Tomas! Pushed to 16.05.x, for 16.05.06 release |