Summary: | Any $t subfields not editable in any framework | ||
---|---|---|---|
Product: | Koha | Reporter: | Michael Kuhn <mik> |
Component: | Cataloging | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, julian.maurice, kyle, m.de.rooy, marjorie.barry-vila, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 17660: #adv is considered as an ad by adblock
[SIGNED-OFF] Bug 17660: #adv is considered as an ad by adblock [PASSED QA] Bug 17660: #adv is considered as an ad by adblock |
Description
Michael Kuhn
2016-11-18 15:05:05 UTC
As pointed out by Marjorie Barry-Vila this behaviour changes when Adblock is deactivated in the local webbrowser. With deactivated Adblock field 773 $t is editable in the framework editor. While with activated adblock all fields are editable but 773 $t. And there is more information: The URL of tab "t" for ANY framework is /cgi-bin/koha/admin/marc_subfields_structure.pl?op=add_form&tagfield=610&frameworkcode=$MON#advt "advt" is considered as an advertisement by Adblock. Created attachment 57649 [details] [review] Bug 17660: #adv is considered as an ad by adblock So let's rename it! Test plan: Edit a $t in any framework, you should be able to unfold the "Advanced constraints" part Created attachment 57660 [details] [review] [SIGNED-OFF] Bug 17660: #adv is considered as an ad by adblock So let's rename it! Test plan: Edit a $t in any framework, you should be able to unfold the "Advanced constraints" part Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 57665 [details] [review] [PASSED QA] Bug 17660: #adv is considered as an ad by adblock So let's rename it! Test plan: Edit a $t in any framework, you should be able to unfold the "Advanced constraints" part Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Jonathan! Pushed to 3.22.x, will be in 3.22.13 Pushed to 16.05.x, for 16.05.06 release |