Description
Jonathan Druart
2016-11-22 08:21:53 UTC
Can we remove Tiny::slurp in the meantime ? (In reply to Marcel de Rooy from comment #1) > Can we remove Tiny::slurp in the meantime ? Path::Tiny you mean? Which alternative do you suggest? I also get lockd: cannot monitor kohadevbox in /var/log/messages of the host. (In reply to Jonathan Druart from comment #2) > (In reply to Marcel de Rooy from comment #1) > > Can we remove Tiny::slurp in the meantime ? > > Path::Tiny you mean? > Which alternative do you suggest? The old way is fine too Do you mean using do instead of eval (i.e. revert of bug 16685)? Strange. It works for my windows box vagrant. Oh right, doesn't use NFS, uses built-in virtualbox driver. Created attachment 57727 [details] [review] Bug 17666 - .perl atomic update does not work under kohadevbox Jonathan, does it work for you with this patch? (In reply to Kyle M Hall from comment #8) > Jonathan, does it work for you with this patch? Yes of course it works but in that case it's certainly better to use File::Slurp::read_file (In reply to Jonathan Druart from comment #9) > (In reply to Kyle M Hall from comment #8) > > Jonathan, does it work for you with this patch? > > Yes of course it works but in that case it's certainly better to use > File::Slurp::read_file File::Slurp is packaged on Debian. It calls sysopen with O_RDONLY. So no flock. So, it seems to be the best choice here. Created attachment 58151 [details] [review] Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp" This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc. On a kohadevbox: Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS Test plan: Execute a .perl atomic update file on a kohadevbox => Without this patch you should get the flock error => With this patch the update should work fine Created attachment 58193 [details] [review] [SIGNED-OFF] Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp" This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc. On a kohadevbox: Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS Test plan: Execute a .perl atomic update file on a kohadevbox => Without this patch you should get the flock error => With this patch the update should work fine Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 58196 [details] [review] Bug 17666: Revert "Bug 16685 [QA Followup] - Use Path::Tiny::slurp instead of File::Slurp" This reverts commit 7ac1bc35372990520a7c67870b2c702c41bbebcc. On a kohadevbox: Error flock (1) on '/home/vagrant/kohaclone/installer/data/mysql/atomicupdate/bug_xxxx.perl': No locks available at installer/data/mysql/updatedatabase.pl line 13637. This is because Path::Tiny->slurp[_utf8] uses flocks which does not work with NFS Test plan: Execute a .perl atomic update file on a kohadevbox => Without this patch you should get the flock error => With this patch the update should work fine Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 58197 [details] [review] Bug 17666: [QA Follow-up] Mark File::Slurp as required Not optional since we are 'using' it in updatedatabase.pl. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Note: Has been packaged for Jessie Pushed to master for 17.05, thanks Jonathan, Marcel! These patches have been pushed to 16.11.x, will be in 16.11.01. |