Summary: | Change URL for Google Scholar in OPACSearchForTitleIn | ||
---|---|---|---|
Product: | Koha | Reporter: | Felix Hemme <felix.hemme> |
Component: | OPAC | Assignee: | Charlotte Cordwell <charlotte.cordwell123> |
Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, fridolin.somers, jonathan.druart, nick |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn
Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn Bug 17682: Replace 2 occurrences in de-DE and nb-NO |
Description
Felix Hemme
2016-11-25 13:20:41 UTC
This will require an update to the default system preferences SQL (variable OPACSearchForTitleIn), and probably a check during update for customized values. Created attachment 70545 [details] [review] Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn 1)apply patch 2) go into administration --> search for OPACSearchForTitleIn 3) *click to edit* 4) look at the link and read the google scholar one. 5) check that the start link is https://scholar.google.com. 6) http://www.scholar.google is incorrect Created attachment 70546 [details] [review] Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn 1)apply patch 2) go into administration --> search for OPACSearchForTitleIn 3) *click to edit* 4) look at the link and read the google scholar one. 5) check that the start link is https://scholar.google.com. 6) http://www.scholar.google is incorrect Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> I think the update needs to target only http://www.scholar.google.com Current code also updates bookfinder URL and breaks it (https seems to work, but requires keeping the 'www.') We can update both above links specifically so we don't hit any extra custom ones Created attachment 70568 [details] [review] Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn Amended the sql statement so it only affects the http://www.scholar.google.com url Current status: Failed QA This is ready for testing. Created attachment 70738 [details] [review] Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn 1)apply patch 2) go into administration --> search for OPACSearchForTitleIn 3) *click to edit* 4) look at the link and read the google scholar one. 5) check that the start link is https://scholar.google.com. 6) http://www.scholar.google is incorrect Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 70739 [details] [review] Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn Amended the sql statement so it only affects the http://www.scholar.google.com url Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Small change, SO and QA in one step Created attachment 70770 [details] [review] Bug 17682: Replace 2 occurrences in de-DE and nb-NO Patches pushed to master for 18.05. Congratulations Charlotte for your first patches in! Awesome work all! Pushed to Stable for 17.11.02 Pushed to 17.05.x for v17.05.09 |