Summary: | Two missing periods in opac-suggestions.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Eric Phetteplace <ephetteplace> |
Component: | OPAC | Assignee: | Eric Phetteplace <ephetteplace> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | alexbuckley, ephetteplace, kyle, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
patch
Bug 17696: missing periods in opac-suggestions.tt Attachment to Bug 17696 - Two missing periods in opac-suggestions.tt Bug 17696: Add 2 missing periods in opac-suggestions.tt |
Description
Eric Phetteplace
2016-11-29 20:14:19 UTC
Created attachment 57809 [details] [review] patch Created attachment 57812 [details] [review] Bug 17696: missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Created attachment 57814 [details] [review] Attachment to Bug 17696 - Two missing periods in opac-suggestions.tt Bug 17696: missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> HEAD detached from origin/master Changes to be committed: modified: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt Created attachment 57831 [details] [review] Bug 17696: Add 2 missing periods in opac-suggestions.tt Problem: - two missing trailing periods in template Test plan: - configure MaxOpenSuggestions with a low limit (e.g. 1) - visit opac-suggestions.pl?op=add, login if necessary - note that the period is missing from the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - continue to submit suggestions until you've reached the MaxOpenSuggestions limit - observe the missing period in the "TooManySuggestionsText" paragraph - apply patch - revisit opac-suggestions.pl?op=add - note that the period is now present in the second sentence of the leading paragraph under the "Enter a new purchase suggestion" heading - note that the period is also present at the end of the "TooManySuggestionsText" paragraph Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Eric! (In reply to Kyle M Hall from comment #5) > Pushed to master for 16.11, thanks Eric! 16.11 or 17.05 ? This patch has been pushed to 16.11.x, will be in 16.11.01. |