| Summary: | Remove itemtype-related t/db_dependent/Members/* warnings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | kyle, mtompset |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings
[SIGNED-OFF] Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings |
||
|
Description
Tomás Cohen Arazi (tcohen)
2016-12-02 17:19:07 UTC
Created attachment 57936 [details] [review] Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings This patch makes t/db_dependent/Members/* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Members/* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Members/* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Created attachment 57943 [details] [review] [SIGNED-OFF] Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings This patch makes t/db_dependent/Members/* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Members/* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Members/* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett <mtompset@hotmail.com> P.S. Overzealous variable renaming item_infos. Still okay, but not necessary. (In reply to M. Tompsett from comment #3) > P.S. Overzealous variable renaming item_infos. Still okay, but not necessary. Heh, I belived %item_branch_info was no longer a correct name, as it now includes 'itype'. But we could have lived without the change, yeah :-D Created attachment 57958 [details] [review] Bug 17714: Remove itemtype-related t/db_dependent/Members/* warnings This patch makes t/db_dependent/Members/* create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Members/* => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Members/* => SUCCESS: Tests are green, and no warnings. - Sign off :-D Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master for 17.05, thanks Tomas! This patch has been pushed to 16.11.x, will be in 16.11.01. |