Summary: | t/db_dependent/PatronLists.t doesn't run inside a transaction | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | Test Suite | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | katrin.fischer, kyle |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 17600 | ||
Attachments: |
Bug 17722: Make PatronLists.t run inside a transaction
[SIGNED-OFF] Bug 17722: Make PatronLists.t run inside a transaction Bug 17722: Make PatronLists.t run inside a transaction |
Description
Tomás Cohen Arazi
2016-12-05 14:11:22 UTC
Created attachment 57968 [details] [review] Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D Created attachment 57986 [details] [review] [SIGNED-OFF] Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57997 [details] [review] Bug 17722: Make PatronLists.t run inside a transaction This patch makes t/db_dependent/PatronLists.t run inside a transaction. It also makes it generate its own data using t::lib::TestBuilder instead of relying on sample patrons on the DB. To test: - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Apply the patch - Run: $ prove t/db_dependent/PatronLists.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master fro 17.05, thanks Tomas! This patch has been pushed to 16.11.x, will be in 16.11.01. |