|
Description
Katrin Fischer
2016-12-05 22:42:46 UTC
Created attachment 58867 [details] [review] Bug 17725: Do not copy subfield's content when cloning To replicate: - Open an existing record in your catalog - Create another field or subfield of a field/subfield already used using the icon to repeat it - Verify that the content is copied over - Verify this happens for input (one line) and textare (multiple lines) I can't make this happen for when creating a new record, but more consistently on editing existing records. This is rather annoying when cataloguing in Koha, as the cataloguer has to empty the field first and that adds an extra step for each repeated field. Test plan: Confirm than the content is not copied when you clone a field or a subfield. I have been unable to fully replicate the issue, but have found one occurance of an "input" field including content when copied. I have successfully replicated the issue with texarea fields (multiple lines). When testing I find the patch has fixed my single "input" field issue. But the "textarea" field still includes content when cloned. Specifically this was 520 $a. Content is still copying across Yes there still remains last occurence of this bug - textareas when clonning whole field - typically 5xx in MARC21 Something that might be good to test: When an input field contains a lot of text, next time you open the record it will be shown as a textarea. The 5xx seem to always display as a textarea. Created attachment 58914 [details] [review] Bug 17725: Same for textarea when cloning a field (In reply to Josef Moravec from comment #3) > Yes there still remains last occurence of this bug - textareas when clonning > whole field - typically 5xx in MARC21 Fixed! Created attachment 58915 [details] [review] [SIGNED-OFF] Bug 17725: Do not copy subfield's content when cloning To replicate: - Open an existing record in your catalog - Create another field or subfield of a field/subfield already used using the icon to repeat it - Verify that the content is copied over - Verify this happens for input (one line) and textare (multiple lines) I can't make this happen for when creating a new record, but more consistently on editing existing records. This is rather annoying when cataloguing in Koha, as the cataloguer has to empty the field first and that adds an extra step for each repeated field. Test plan: Confirm than the content is not copied when you clone a field or a subfield. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 58916 [details] [review] [SIGNED-OFF] Bug 17725: Same for textarea when cloning a field Signed-off-by: Josef Moravec <josef.moravec@gmail.com> (In reply to Katrin Fischer from comment #4) > Something that might be good to test: When an input field contains a lot of > text, next time you open the record it will be shown as a textarea. The 5xx > seem to always display as a textarea. Tested, and looks fine (In reply to Josef Moravec from comment #9) > (In reply to Katrin Fischer from comment #4) > > Something that might be good to test: When an input field contains a lot of > > text, next time you open the record it will be shown as a textarea. The 5xx > > seem to always display as a textarea. > > Tested, and looks fine Thx, Josef! Created attachment 58944 [details] [review] Bug 17725: Do not copy subfield's content when cloning To replicate: - Open an existing record in your catalog - Create another field or subfield of a field/subfield already used using the icon to repeat it - Verify that the content is copied over - Verify this happens for input (one line) and textare (multiple lines) I can't make this happen for when creating a new record, but more consistently on editing existing records. This is rather annoying when cataloguing in Koha, as the cataloguer has to empty the field first and that adds an extra step for each repeated field. Test plan: Confirm than the content is not copied when you clone a field or a subfield. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 58945 [details] [review] Bug 17725: Same for textarea when cloning a field Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.05, thanks Jonathan! These patches have been pushed to 16.11.x and will be in 16.11.02. . Blocked by enhancement, skipping for 16.05.x |