Summary: | Use Koha::Patron->holds in Koha::Patron->delete | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris.kirby, katrin.fischer, kyle, m.de.rooy |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 17740 | ||
Bug Blocks: | |||
Attachments: |
Bug 17741: Use Koha::Patron->holds when deleting a patron
[SIGNED-OFF] Bug 17741: Use Koha::Patron->holds when deleting a patron Bug 17741: Use Koha::Patron->holds when deleting a patron |
Description
Jonathan Druart
2016-12-07 16:33:39 UTC
Created attachment 58022 [details] [review] Bug 17741: Use Koha::Patron->holds when deleting a patron There is a TODO in Koha::Patron->delete, this method should call the Koha::Patron->holds to retrieve the holds made by the patron we are removing instead of calling Koha::Holds->search Test plan: prove t/db_dependent/Koha/Patrons.t Should return green Created attachment 58034 [details] [review] [SIGNED-OFF] Bug 17741: Use Koha::Patron->holds when deleting a patron There is a TODO in Koha::Patron->delete, this method should call the Koha::Patron->holds to retrieve the holds made by the patron we are removing instead of calling Koha::Holds->search Test plan: prove t/db_dependent/Koha/Patrons.t Should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> I tested this too, but I get "Compilation failed in require at Koha/ArticleRequest.pm" and "Compilation failed in require at Koha/Patron.pm" errors. And the tests fail. I have updated my packages. Now I get "Parse errors: Bad plan. You planned 15 tests but ran 9." "Failed test 'No tests run for subtest "is_going_to_expire"' The method is_going_to_expire_expire is not covered by tests!" Within the staff client, when I delete a patron with a hold, I get a "The method holds is not covered by tests!" error message. Everything looks ok for me, please apply the dependencies first. Created attachment 58627 [details] [review] Bug 17741: Use Koha::Patron->holds when deleting a patron There is a TODO in Koha::Patron->delete, this method should call the Koha::Patron->holds to retrieve the holds made by the patron we are removing instead of calling Koha::Holds->search Test plan: prove t/db_dependent/Koha/Patrons.t Should return green Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Jonathan! This won't get ported back to 16.11.x as it is an enhancement. |