Summary: | Fixing theoretical problems with guarantorid in Members.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, katrin.fischer, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 17733 | ||
Bug Blocks: | |||
Attachments: |
Bug 17759: Remove invalid guarantorid's in Members.t
Bug 17759: Remove invalid guarantorid's in Members.t |
Description
Marcel de Rooy
2016-12-12 11:50:49 UTC
Created attachment 58117 [details] [review] Bug 17759: Remove invalid guarantorid's in Members.t See also bug 17733. As long as we have no FK, these invalid guarantorid's can make tests fail. Adding a sql statement to clear them in the beginning of the test. Test plan: [1] Since it seems that AUTO_INC+8, +9 and +10 may fail one or two tests, we should manipulate one or two borrowers: Run this SQL query first: SELECT `AUTO_INCREMENT` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = '[your database]' and table_name='borrowers'; Now run: UPDATE borrowers SET guarantorid=[former value + 8] WHERE borrowernumber=[some existing borrowernumber] [2] Without this patch, run Members.t. Should fail two tests. [3] Apply the patch. Fetch the new AUTO_INCREMENT value and update guarantorid accordingly again for the manipulated borrower. [4] Run the test. It should not fail. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 58119 [details] [review] Bug 17759: Remove invalid guarantorid's in Members.t See also bug 17733. As long as we have no FK, these invalid guarantorid's can make tests fail. Adding a sql statement to clear them in the beginning of the test. Test plan: [1] Since it seems that AUTO_INC+8, +9 and +10 may fail one or two tests, we should manipulate one or two borrowers: Run this SQL query first: SELECT `AUTO_INCREMENT` FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = '[your database]' and table_name='borrowers'; Now run: UPDATE borrowers SET guarantorid=[former value + 8] WHERE borrowernumber=[some existing borrowernumber] [2] Without this patch, run Members.t. Should fail two tests. [3] Apply the patch. Fetch the new AUTO_INCREMENT value and update guarantorid accordingly again for the manipulated borrower. [4] Run the test. It should not fail. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Skipping QA, too much time spent on these tests already. Pushed to master for 17.05, thanks Marcel! This patch has been pushed to 16.11.x, will be in 16.11.01. |